Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-164082851
@shivaram Will it be merged before the release of 1.6? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-164110535
Sorry @gatorsmile -- I missed this PR for a couple of days. LGTM. Merging
this to master and `branch-1.6`. Regarding whether this will make 1.6 release,
it depends
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-164118736
Thank you, everyone! : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162638331
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162639405
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162639971
**[Test build #47279 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47279/consoleFull)**
for PR 10160 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162640410
**[Test build #47280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47280/consoleFull)**
for PR 10160 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162646030
**[Test build #47279 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47279/consoleFull)**
for PR 10160 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162646208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162648890
**[Test build #47280 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47280/consoleFull)**
for PR 10160 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162649168
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162649173
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46877998
--- Diff: R/pkg/R/DataFrame.R ---
@@ -677,13 +677,17 @@ setMethod("unique",
#' collect(sample(df, TRUE, 0.5))
#'}
setMethod("sample",
-
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46882887
--- Diff: R/pkg/R/DataFrame.R ---
@@ -677,13 +677,17 @@ setMethod("unique",
#' collect(sample(df, TRUE, 0.5))
#'}
setMethod("sample",
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162675926
Thank you, @shivaram @felixcheung !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162675821
looks good thanks @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162679654
**[Test build #47287 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47287/consoleFull)**
for PR 10160 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162685529
**[Test build #47287 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47287/consoleFull)**
for PR 10160 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162685711
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162685717
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-16262
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162626664
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162628586
looks good.
Jenkins could you retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162618530
@gatorsmile This will need to be rebased to master as we moved test file
locations in #10030 -- Let me know once thats done and I'll merge
---
If your project is set
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162412228
@gatorsmile Sure - I guess the main thing is to ensure the seed is getting
set. How about:
```
count1 <- count(sample(df, FALSE, 0.1, 0))
count2 <-
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162413477
Yeah thats a good idea @felixcheung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162418099
**[Test build #47253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47253/consoleFull)**
for PR 10160 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162415274
@felixcheung @shivaram Sure, just added that test case. Please review it.
Thank you! : )
---
If your project is set up for it, you can reply to this email and have
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46788107
--- Diff: R/pkg/R/DataFrame.R ---
@@ -692,8 +694,12 @@ setMethod("sample",
setMethod("sample_frac",
signature(x = "DataFrame",
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162415989
**[Test build #47253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47253/consoleFull)**
for PR 10160 at commit
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162415645
LGTM. I'll wait for @felixcheung and Jenkins before merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46788421
--- Diff: R/pkg/R/DataFrame.R ---
@@ -677,13 +677,15 @@ setMethod("unique",
#' collect(sample(df, TRUE, 0.5))
#'}
setMethod("sample",
-
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162417739
**[Test build #47254 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47254/consoleFull)**
for PR 10160 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46789803
--- Diff: R/pkg/R/DataFrame.R ---
@@ -692,8 +696,8 @@ setMethod("sample",
setMethod("sample_frac",
signature(x = "DataFrame",
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162427732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162428939
@shivaram @felixcheung @sun-rui Thank you everyone! Hopefully, my code
changes resolve all your concerns. I learned a lot from you! : )
---
If your project is set
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46788139
--- Diff: R/pkg/R/DataFrame.R ---
@@ -677,13 +677,15 @@ setMethod("unique",
#' collect(sample(df, TRUE, 0.5))
#'}
setMethod("sample",
-
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46789542
--- Diff: R/pkg/R/DataFrame.R ---
@@ -692,8 +696,8 @@ setMethod("sample",
setMethod("sample_frac",
signature(x = "DataFrame",
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162424451
**[Test build #47255 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47255/consoleFull)**
for PR 10160 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162418156
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46789026
--- Diff: R/pkg/R/DataFrame.R ---
@@ -692,8 +696,8 @@ setMethod("sample",
setMethod("sample_frac",
signature(x = "DataFrame",
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162418157
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162419603
**[Test build #47254 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47254/consoleFull)**
for PR 10160 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162419713
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162419711
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162427729
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162427500
**[Test build #47255 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47255/consoleFull)**
for PR 10160 at commit
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/10160#issuecomment-162431824
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
49 matches
Mail list logo
