[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-16 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-165272375 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-16 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/10165 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-164626233 Sure, will do it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-164624910 Can you add a test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-163093753 Thank you! @cloud-fan Will this PR be merged to 1.6? Or waiting for another PR for showing decoded values? @marmbrus Thank you! --- If your project is set

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-07 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162715388 the truncate logic is already in `DataFrame.showString`: `if (truncate && str.length > 20) str.substring(0, 17) + "..." else str`, so this LGTM. --- If your project

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-07 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162705189 @marmbrus Agree. It will truncate if we use the default value. For example, ```scala ds.show(20); ``` For showing the decoded values, I can

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-07 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162704070 Showing hex for binary columns seems reasonable, though we should probably truncate if its long. Showing the object representation for oparquely encoded values also s

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162400140 I have the exact same question when calling the show function. From the perspectives of users, they might not care the encoded values at all when calling the functio

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162396682 Shoud we print the decoded values(user objects) in `Dataset.show`? cc @marmbrus @rxin --- If your project is set up for it, you can reply to this email and have you

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162344227 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162344226 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162343924 **[Test build #47244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47244/consoleFull)** for PR 10165 at commit [`5d0d64c`](https://g

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-162334416 **[Test build #47244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47244/consoleFull)** for PR 10165 at commit [`5d0d64c`](https://gi

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-06 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/10165 [SPARK-12164] [SQL] Display the binary/encoded values When the dataset is encoded, the existing display looks strange. Decimal format is not common when the type is binary. ``` impl