Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-173033632
LGTM. Thanks for this PR and apologies for the delay in getting back on
this. Merging to master.
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-172147097
@shivaram please review when you get a chance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-167893375
@shivaram how about I open a different PR on adding `--vanilla` to
`RRunner`?
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-167463955
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-167463702
**[Test build #48357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48357/consoleFull)**
for PR 10171 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-167462209
**[Test build #48357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48357/consoleFull)**
for PR 10171 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-167463954
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-166189995
@shivaram what do you think about adding `--vanilla` to `RRunner`
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-164852205
@gatorsmile I reported the spam to Github, who said Apache had to block
them. I was about to contact them, but, realized I don't see the spam comments
anymore. Is it
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-164861506
@srowen ! It sounds like his mailing app is hacked. Hopefully, it will not
happen again! Thank you!
---
If your project is set up for it, you can reply to this
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-164685724
Well, that was the first thing I tried :)
```
Exception in thread "main" java.io.IOException: Cannot run program "Rscript
--vanilla": error=2, No such file
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-164680613
Just set "spark.r.driver.command" to be "Rscript --vanilla " seems workable?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-164720360
@felixcheung, maybe we always set the "--vanilla" option in RRuner? as this
is done in RRDD, see
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-164673668
Can anybody stop @3ourroom ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-164672322
I think we should run tests with --vanilla (or equivalent) to make it
cleaner?
Though it seems we don't have a way to specify options to Rscript
Github user 3ourroom commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-164672736
NAVER - http://www.naver.com/
3ourr...@naver.com ëê» ë³´ë´ì ë©ì¼ ì´ ë¤ìê³¼ ê°ì ì´ì ë¡
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-164369645
To avoid the interference of user loaded packages for this test, we may:
1. Add --vanilla option to R when running tests;
2. or is it possible to pick only
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-162639856
@shivaram `conflicts` would return any object that is masked, so that could
involve local objects/variables. You can see the example with `lm`
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-162622764
Thanks @felixcheung -- this is an interesting approach. Do you know if
`conflicts` captures data structures or S4 classes with same name as well ?
Also we'd need to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-162414262
**[Test build #47252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47252/consoleFull)**
for PR 10171 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-162416192
**[Test build #47252 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47252/consoleFull)**
for PR 10171 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-162416419
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10171#issuecomment-162416422
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/10171
[SPARK-12168][SPARKR] Add automated tests for conflicted function in R
Currently this is reported when loading the SparkR package in R (probably
would add is.nan)
```
Loading required
25 matches
Mail list logo
