Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-169087339
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168900177
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168900175
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168899568
**[Test build #48721 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48721/consoleFull)**
for PR 10390 at commit
[`80a3f7b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168877970
**[Test build #48721 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48721/consoleFull)**
for PR 10390 at commit
[`80a3f7b`](https://gi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10390#discussion_r48808392
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
---
@@ -242,6 +242,16 @@ class ExpressionEncoderSui
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10390#discussion_r48807733
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -94,6 +99,9 @@ class UserDefinedTypeSuite extends QueryTest with
Sha
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10390#discussion_r48780378
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
---
@@ -242,6 +242,16 @@ class ExpressionEncoderS
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10390#discussion_r48780302
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -94,6 +99,9 @@ class UserDefinedTypeSuite extends QueryTest with
S
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168165273
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168165278
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168165009
**[Test build #48548 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48548/consoleFull)**
for PR 10390 at commit
[`62fa738`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168153873
**[Test build #48548 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48548/consoleFull)**
for PR 10390 at commit
[`62fa738`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168150653
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168150645
**[Test build #48547 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48547/consoleFull)**
for PR 10390 at commit
[`72446f1`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168150652
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168150125
**[Test build #48547 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48547/consoleFull)**
for PR 10390 at commit
[`72446f1`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168127437
@cloud-fan I just think the same thing. I will try it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168127250
We alread have UDT in
[`RowEncoderSuite`](https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168113152
@marmbrus Not only MyLabeledPoint, which is just a case class. Also
including UDT MyDenseVectorUDT and MyDenseVector. I think it might duplicate
too many lines of codes
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-168050667
Do you mean just the example UDT `MyLabeledPoint`? I'm fine with
duplicating that or moving it entirely. If UDTs are defined in catalyst we
should also have unit tes
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-167975129
**[Test build #48468 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48468/consoleFull)**
for PR 10390 at commit
[`42303d2`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-167975181
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-167975180
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-167960014
**[Test build #48468 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48468/consoleFull)**
for PR 10390 at commit
[`42303d2`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-167954678
@marmbrus Thanks. However, to move the test means that we need to move the
UDT classes to encoder tests. I think it might duplicate the codes. Is it ok
for you?
---
If
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-167648261
Okay, I'm fine with merging this now to unblock other progress. However, I
think we should move the test to be with the other encoder tests.
---
If your project is s
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166473725
Personally, I would like to see this to be merged because it blocks my
another PR #10283. Can we merge this and go back to modify this part when we
revamp UDT API in the
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166445780
We can revisit this if we do a 1.7 release, but I don't think that is going
to happen.
---
If your project is set up for it, you can reply to this email and have your
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166445480
That is fine. But we will leave it broken until Spark2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166403465
I think we need more design work before we implement this. I'm not a huge
fan of the current UDT API and I think we will replace it in Spark 2.0.
---
If your project
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10390#discussion_r48132773
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -81,6 +81,9 @@ object Cast {
toField.n
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166245845
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166245847
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166245642
**[Test build #48100 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48100/consoleFull)**
for PR 10390 at commit
[`d01c661`](https://g
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10390#discussion_r48125827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -81,6 +81,9 @@ object Cast {
toField.n
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10390#discussion_r48123608
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -81,6 +81,9 @@ object Cast {
toFiel
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166226967
**[Test build #48100 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48100/consoleFull)**
for PR 10390 at commit
[`d01c661`](https://gi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10390#discussion_r48122523
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -89,6 +94,23 @@ class UserDefinedTypeSuite extends QueryTest with
Sh
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10390#discussion_r48113653
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/UserDefinedTypeSuite.scala ---
@@ -89,6 +94,23 @@ class UserDefinedTypeSuite extends QueryTest with
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-166181434
cc @cloud-fan @marmbrus @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-165975417
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-165975421
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-165975326
**[Test build #48050 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48050/consoleFull)**
for PR 10390 at commit
[`51b76b1`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10390#issuecomment-165961628
**[Test build #48050 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48050/consoleFull)**
for PR 10390 at commit
[`51b76b1`](https://gi
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/10390
[SPARK-12438][SQL] Add SQLUserDefinedType support for encoder
JIRA: https://issues.apache.org/jira/browse/SPARK-12438
ScalaReflection lacks the support of SQLUserDefinedType. We should add i
47 matches
Mail list logo
