Github user robbinspg commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168973101
created https://issues.apache.org/jira/browse/SPARK-12647 and associated PR
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user robbinspg commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168963270
I have a fix for the test failure. Should I create a new Jira and PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168919543
cc @yhuai on this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user robbinspg commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168919276
Merging this into the 1.6 stream has caused a test failure in
org.apache.spark.sql.execution.ExchangeCoordinatorSuite.determining the
number of reducers: agg
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168765217
Merged into master and 1.6 branch, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10421
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168287520
I will let @davies merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168268755
**[Test build #2282 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2282/consoleFull)**
for PR 10421 at commit
[`e5a8d1e`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168259354
**[Test build #2282 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2282/consoleFull)**
for PR 10421 at commit
[`e5a8d1e`](https://g
Github user robbinspg commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168172679
re-merged with latest master
Please retest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10421#discussion_r48639583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeRowJoiner.scala
---
@@ -171,7 +171,7 @@ object Generate
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168095060
**[Test build #2273 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2273/consoleFull)**
for PR 10421 at commit
[`1a09c7a`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168091850
**[Test build #2273 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2273/consoleFull)**
for PR 10421 at commit
[`1a09c7a`](https://g
Github user robbinspg commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168091202
Fixed scala style check
Please retest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168048643
OK to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168048356
**[Test build #2268 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2268/consoleFull)**
for PR 10421 at commit
[`12724b3`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168048153
**[Test build #2268 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2268/consoleFull)**
for PR 10421 at commit
[`12724b3`](https://g
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168048077
LGTM, pending for tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user robbinspg commented on a diff in the pull request:
https://github.com/apache/spark/pull/10421#discussion_r48599743
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeRowJoiner.scala
---
@@ -171,7 +171,7 @@ object Gener
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10421#discussion_r48562209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeRowJoiner.scala
---
@@ -171,7 +171,7 @@ object Generate
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-167855300
@rxin I had finished the refactoring long time ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-167738673
I think @davies did some pretty big refactoring of this later. @davies can
you take a quick look at this? Thanks.
---
If your project is set up for it, you can reply to
Github user robbinspg commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-167738123
@rxin as the original author of this code could you please review the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear
23 matches
Mail list logo
