[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167688409 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167688408 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10441 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167685179 okey :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167685127 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167685120 The relevant UI tests all passed and the only failures were due to a known flaky test / build executor, so I'm going to merge this into master. Thanks! --- If your p

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167684908 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167684883 **[Test build #48378 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48378/consoleFull)** for PR 10441 at commit [`fd2d1f2`](https://g

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167684909 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167677076 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167677083 **[Test build #48378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48378/consoleFull)** for PR 10441 at commit [`fd2d1f2`](https://gi

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48511839 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1232,24 +1243,16 @@ private[ui] class TaskPagedTable( override d

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167675703 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167675690 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167675687 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167672868 @zsxwing, I've pushed a new commit which aims to preserve the old behavior when increasing the number of items displayed per page while pageNumber > 1; see fd2d1f2a49

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48324440 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1232,24 +1243,16 @@ private[ui] class TaskPagedTable( override def

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48323623 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1232,24 +1243,16 @@ private[ui] class TaskPagedTable( override d

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166806883 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166806884 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166806823 **[Test build #48227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48227/consoleFull)** for PR 10441 at commit [`89827a5`](https://g

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166795272 **[Test build #48227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48227/consoleFull)** for PR 10441 at commit [`89827a5`](https://gi

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166777567 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166777564 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166777114 **[Test build #48221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48221/consoleFull)** for PR 10441 at commit [`970be95`](https://g

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48314324 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1232,24 +1243,16 @@ private[ui] class TaskPagedTable( override d

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48314294 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1232,24 +1243,16 @@ private[ui] class TaskPagedTable( override def

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48313993 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1232,24 +1243,16 @@ private[ui] class TaskPagedTable( override d

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166766454 **[Test build #48221 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48221/consoleFull)** for PR 10441 at commit [`970be95`](https://gi

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166765248 > Note that my exception changes were actually motivated by a case where this error-handling logic swallowed other internal exceptions and only printed "1" as output. T

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166765190 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166764047 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166764008 **[Test build #48216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48216/consoleFull)** for PR 10441 at commit [`970be95`](https://g

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166764045 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166756541 Note that my exception changes were actually motivated by a case where this error-handling logic swallowed other internal exceptions and only printed "1" as output. T

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166754320 LGTM except my comments about `Utils.exceptionString` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48305789 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -295,7 +295,14 @@ private[ui] class StagePage(parent: StagesTab) extends WebUIP

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48305560 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1232,24 +1243,16 @@ private[ui] class TaskPagedTable( override def

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48305122 --- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala --- @@ -95,7 +106,12 @@ private[ui] trait PagedTable[T] { val PageData(totalPa

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-166746163 **[Test build #48216 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48216/consoleFull)** for PR 10441 at commit [`970be95`](https://gi

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48303869 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1232,24 +1243,16 @@ private[ui] class TaskPagedTable( override d

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-22 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/10441 [SPARK-12490] Don't use Javascript for web UI's paginated table controls The web UI's paginated table uses Javascript to implement certain navigation controls, such as table sorting and the "go t