Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/10481#discussion_r48518527
--- Diff: R/pkg/R/column.R ---
@@ -225,7 +225,7 @@ setMethod("%in%",
setMethod("otherwise",
signature(x = "Column", value = "ANY"),
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167540565
The fix is good, but some style nit:
if (...) { ... } else { ... }
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167649006
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167649007
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user saurfang commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167717447
Thanks for the review @sun-rui. Hope that's better. Looks like `lintr`, as
awesome as it is, let that slip through, which I have filed a separate issue
here:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167718452
**[Test build #48395 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48395/consoleFull)**
for PR 10481 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167730405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167730355
**[Test build #48395 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48395/consoleFull)**
for PR 10481 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167730404
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167735437
LGTM. Thanks @saurfang and @sun-rui - Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167330045
Thanks @saurfang for the PR. I think this is a good enough fix as this is
in an internal implementation detail and not visible to SparkR users ?
cc @sun-rui
Github user saurfang commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167376718
Indeed. Like I said I don't see compelling reason to use these three
functions in vectorized way. Let me know if you have any other comments on the
fix.
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167281017
**[Test build #48336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48336/consoleFull)**
for PR 10481 at commit
GitHub user saurfang opened a pull request:
https://github.com/apache/spark/pull/10481
[SPARK-12526][SPARKR]`ifelse`, `when`, `otherwise` unable to take Column as
value
`ifelse`, `when`, `otherwise` is unable to take `Column` typed S4 object as
values.
For example:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167281714
**[Test build #48336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48336/consoleFull)**
for PR 10481 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167281934
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10481#issuecomment-167281935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
18 matches
Mail list logo
