Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167834296
Can you update the pr? Once it passes jenkins, I will merge it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167848836
@yhuai, do you mean that I would update all of the string concatenation in
@ExpressionDescription by using multi-line string literals rather than only the
original one?
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167834026
@kiszk Thank you for the investigation. Yeah, let's use multi-line string
literals. If we have to have a line with more than 100 characters, let's use
`// scalastyle:off
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167849606
Let me merge this one first to fix the spark master maven snapshot. Then,
can you create another jira to update other places?
---
If your project is set up for it, you
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167853136
I see. I will create another JIRA entry to update other usages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48534614
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression) extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48534869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression) extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48475897
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression)
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48472393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression) extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48470392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression)
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48475242
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression)
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167540178
@yhuai can you take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48479722
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression)
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48495327
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression) extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48503757
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression) extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48498744
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression) extends
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167630559
I am going to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48499260
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression) extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48500579
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression)
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48499035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression) extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48500799
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression) extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10488#discussion_r48514250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -57,9 +57,10 @@ case class Md5(child: Expression)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167401548
**[Test build #48348 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48348/consoleFull)**
for PR 10488 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167401573
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167401572
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/10488
[SPARK-12530][Build] Fix build break at Spark-Master-Maven-Snapshots from
#1293
Compilation error caused due to string concatenations that are not a
constant
Use raw string literal to avoid
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167396615
**[Test build #48348 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48348/consoleFull)**
for PR 10488 at commit
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167418794
Thanks for letting me know them. I will check them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167424111
@hvanhovell, a set of following two conditions causes this compilation
failure:
1. Use more than one string concatenations
2. Use scala 2.11 compiler (open
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167418258
There a quite a few builds passing which are using string concatenation in
combination with ```ExpressionDescription```:
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10488#issuecomment-167506758
More people are having this problem. Lets use raw strings then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
32 matches
Mail list logo
