Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53568446
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,42 @@ object functions extends LegacyFunctions {
new Mu
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186738840
Thanks so much for suggestion! I will open a new PR for update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186738494
Sorry missed the symmetry part, but it is symmetric underneath, except
`AesDecrypt` wrap the bytes into a string at last. We should return binary
directly, sorry for
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186528815
I would also just remove support for 192/256, so we don't have to explain
the JCE stuff.
---
If your project is set up for it, you can reply to this email and have your
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53546094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -442,3 +444,90 @@ case class PrintToStderr(child: Expression)
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53546060
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -442,3 +444,90 @@ case class PrintToStderr(child: Expression)
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53546023
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,42 @@ object functions extends LegacyFunctions {
new Murmur3
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186523636
Ok, Sure. I will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186523782
I did not look into this closely, since @cloud-fan already reviewed this
many rounds. sorry for the rush.
---
If your project is set up for it, you can reply to this em
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186523445
@vectorijk I've reverted the patch. Can you reopen the pull request and fix
the return types?
---
If your project is set up for it, you can reply to this email and have
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53546006
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,42 @@ object functions extends LegacyFunctions {
new Murmu
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186523374
Sorry I'm not convinced this is correct (decrypt returning string type),
and there are other issues with it. I'm just going to revert the patch, since
it is unlikely other
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186522894
@davies does this implementation even make sense? decrypt always return a
string, while encrypt always take in a binary? The two are not symmetric.
---
If your proj
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53545904
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,42 @@ object functions extends LegacyFunctions {
new Mu
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53545906
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,42 @@ object functions extends LegacyFunctions {
new Murmur3
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53545875
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,42 @@ object functions extends LegacyFunctions {
new Murmu
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10527
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53545860
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,42 @@ object functions extends LegacyFunctions {
new Murmur3
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53545856
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions {
new Murmur3
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186520228
LGTM, merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186184785
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186184787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186184562
**[Test build #51551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51551/consoleFull)**
for PR 10527 at commit
[`0856fb0`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186180682
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186180676
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186180158
**[Test build #51549 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51549/consoleFull)**
for PR 10527 at commit
[`60b9da7`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186159941
**[Test build #51551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51551/consoleFull)**
for PR 10527 at commit
[`0856fb0`](https://gi
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53442582
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,88 @@ class MiscFunctionsSuite
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186147572
**[Test build #51549 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51549/consoleFull)**
for PR 10527 at commit
[`60b9da7`](https://gi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53442267
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,88 @@ class MiscFunctionsSuite
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186147409
LGTM overall
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53440993
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,92 @@ class MiscFunctionsSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53435449
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,92 @@ class MiscFunctionsSuite
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53431980
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,69 @@ class MiscFunctionsSuite
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r53431192
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions {
new Mu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186029116
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186029112
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186028961
**[Test build #51508 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51508/consoleFull)**
for PR 10527 at commit
[`8e2960c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-186007811
**[Test build #51508 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51508/consoleFull)**
for PR 10527 at commit
[`8e2960c`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-185644283
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-185644281
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-185644151
**[Test build #51476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51476/consoleFull)**
for PR 10527 at commit
[`dc76057`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-185615325
**[Test build #51476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51476/consoleFull)**
for PR 10527 at commit
[`dc76057`](https://gi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52838489
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,69 @@ class MiscFunctionsSuite
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52837685
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions {
new Mu
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52836278
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions {
new Murmu
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52836274
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions {
new Murmu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-183633038
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-183633037
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-183632986
**[Test build #51235 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51235/consoleFull)**
for PR 10527 at commit
[`6bc1b63`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-183624210
**[Test build #51235 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51235/consoleFull)**
for PR 10527 at commit
[`6bc1b63`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-183623401
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-183623402
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-183616365
@cloud-fan Thanks so much for your code review! There is the update for the
doc and error cases review.:)
---
If your project is set up for it, you can reply to
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52824805
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions {
new Mu
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52693618
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions {
new Murmu
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-182851174
LGTM except some minor comments, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-182851144
LGTM except some minor comments, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52597354
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,47 @@ class MiscFunctionsSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52597144
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -442,3 +444,88 @@ case class PrintToStderr(child: Expres
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52596991
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -442,3 +444,88 @@ case class PrintToStderr(child: Expres
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52554453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -442,3 +444,88 @@ case class PrintToStderr(child: Expres
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r52387433
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -442,3 +444,88 @@ case class PrintToStderr(child: Expres
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-182076974
**[Test build #50990 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50990/consoleFull)**
for PR 10527 at commit
[`1de0453`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-182078190
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-182078182
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-182034604
**[Test build #50990 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50990/consoleFull)**
for PR 10527 at commit
[`1de0453`](https://gi
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51685863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -453,3 +455,119 @@ case class Murmur3Hash(children: Seq[
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51685577
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -453,3 +455,119 @@ case class Murmur3Hash(children: Seq[
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51682076
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -453,3 +455,119 @@ case class Murmur3Hash(children: Seq[
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51372548
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -453,3 +455,119 @@ case class Murmur3Hash(children: Seq[Expre
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51372496
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -453,3 +455,119 @@ case class Murmur3Hash(children: Seq[
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51372158
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -453,3 +455,119 @@ case class Murmur3Hash(children: Seq[Expre
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51371194
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -453,3 +455,119 @@ case class Murmur3Hash(children: Seq[
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-177415020
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-177415021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-177414971
**[Test build #50457 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50457/consoleFull)**
for PR 10527 at commit
[`04a14cf`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-177402811
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-177402801
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-177402550
**[Test build #50456 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50456/consoleFull)**
for PR 10527 at commit
[`3a2510b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-177399861
**[Test build #50457 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50457/consoleFull)**
for PR 10527 at commit
[`04a14cf`](https://gi
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51355228
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,49 @@ class MiscFunctionsSuite
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-177383345
**[Test build #50456 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50456/consoleFull)**
for PR 10527 at commit
[`3a2510b`](https://gi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51355182
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,49 @@ class MiscFunctionsSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51355177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -453,3 +455,119 @@ case class Murmur3Hash(children: Seq[
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-177379953
@cloud-fan Okay, addressed comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51176492
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala
---
@@ -132,4 +132,49 @@ class MiscFunctionsSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10527#discussion_r51175633
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -453,3 +455,131 @@ case class Murmur3Hash(children: Seq[
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175987441
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175987440
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175987185
**[Test build #50243 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50243/consoleFull)**
for PR 10527 at commit
[`9476822`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175932477
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175932469
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175927638
**[Test build #50243 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50243/consoleFull)**
for PR 10527 at commit
[`9476822`](https://gi
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175924450
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175813083
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175813070
**[Test build #50212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50212/consoleFull)**
for PR 10527 at commit
[`9476822`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175813080
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175812617
**[Test build #50212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50212/consoleFull)**
for PR 10527 at commit
[`9476822`](https://gi
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-175810046
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
1 - 100 of 141 matches
Mail list logo
