[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168764660 Also merging to branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168762994 Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168762943 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10519#discussion_r48762926 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -34,10 +35,31 @@ import org.apache.spark.sql.{Dat

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10519#discussion_r48762855 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -34,10 +35,31 @@ import org.apache.spark.sql.{Dat

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168751741 Looks good to me. Just have a quick clarification question. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10519#discussion_r48758295 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -34,10 +35,31 @@ import org.apache.spark.sql.{DataFra

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10519#discussion_r48758188 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -34,10 +35,31 @@ import org.apache.spark.sql.{DataFra

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168646362 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168646360 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168645890 **[Test build #48647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48647/consoleFull)** for PR 10519 at commit [`3554d68`](https://g

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168620703 **[Test build #48647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48647/consoleFull)** for PR 10519 at commit [`3554d68`](https://gi

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168617582 /cc @yhuai @marmbrus or @rxin for a review pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168617538 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2016-01-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-168435471 I'd appreciate any feedback on how we can/should test this change and prevent this behavior from regressing in the future. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-167938479 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2015-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-167938480 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-167938457 **[Test build #48446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48446/consoleFull)** for PR 10519 at commit [`3554d68`](https://g

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2015-12-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10519#issuecomment-167931687 **[Test build #48446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48446/consoleFull)** for PR 10519 at commit [`3554d68`](https://gi

[GitHub] spark pull request: [SPARK-12579][SQL] Force user-specified JDBC d...

2015-12-29 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/10519 [SPARK-12579][SQL] Force user-specified JDBC driver to take precedence Spark SQL's JDBC data source allows users to specify an explicit JDBC driver to load (using the `driver` argument), but in t