Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169371791
Added support for more expressions and logical plans. Now 94.2% queries in
`HiveCompatibilitySuite` are covered (window functions are not included in this
suite). Uns
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169240458
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169240459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169240324
**[Test build #48828 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48828/consoleFull)**
for PR 10541 at commit
[`83e28fc`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169217026
**[Test build #48828 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48828/consoleFull)**
for PR 10541 at commit
[`83e28fc`](https://gi
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169216410
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169213941
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169213939
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169186628
Tests finally pass! (The last build failure was actually triggered by an
older commit.)
---
If your project is set up for it, you can reply to this email and have yo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169133875
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169133877
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169133557
**[Test build #48779 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48779/consoleFull)**
for PR 10541 at commit
[`1796540`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169122807
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169122812
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169122517
**[Test build #48781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48781/consoleFull)**
for PR 10541 at commit
[`a8805dd`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169097360
**[Test build #48781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48781/consoleFull)**
for PR 10541 at commit
[`a8805dd`](https://gi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48879512
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -213,6 +215,34 @@ case class Literal protected (valu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169092952
**[Test build #48779 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48779/consoleFull)**
for PR 10541 at commit
[`1796540`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169046403
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169046409
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169046102
**[Test build #48763 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48763/consoleFull)**
for PR 10541 at commit
[`1e50288`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168982479
**[Test build #48763 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48763/consoleFull)**
for PR 10541 at commit
[`1e50288`](https://gi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48803221
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48802965
--- Diff:
sql/hive/src/main/antlr3/org/apache/spark/sql/parser/SparkSqlParser.g ---
@@ -1,9 +1,9 @@
/**
- Licensed to the Apache Software Founda
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48799678
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -213,6 +215,34 @@ case class Literal protected (valu
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48799646
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -74,6 +74,12 @@ case class If(predicat
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48796988
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -226,6 +234,10 @@ case class InSet(child: Expressi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48796917
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -458,7 +458,9 @@ case class Limit(limitExpr:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48792346
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48792162
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48791979
--- Diff:
sql/hive/src/main/antlr3/org/apache/spark/sql/parser/SparkSqlParser.g ---
@@ -1,9 +1,9 @@
/**
- Licensed to the Apache Software Foundation
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48791866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -458,7 +458,9 @@ case class Limit(limitExpr: Exp
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48791753
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -226,6 +234,10 @@ case class InSet(child: Expression,
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48791550
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala ---
@@ -130,6 +130,17 @@ package object util {
ret
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48791317
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -213,6 +215,34 @@ case class Literal protected (value: A
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48791281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -213,6 +215,34 @@ case class Literal protected (value: A
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48791158
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -213,6 +215,34 @@ case class Literal protected (value: A
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48791064
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -74,6 +74,12 @@ case class If(predicate: E
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168781095
@liancheng
One thing about testing infrastructure: It is a good idea to use the
existing Hive compatibility tests to bootstrap your test coverage. However, for
e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168756602
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168756600
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168756348
**[Test build #48667 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48667/consoleFull)**
for PR 10541 at commit
[`1d5dd3b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168737626
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168737620
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168737378
**[Test build #48665 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48665/consoleFull)**
for PR 10541 at commit
[`70af178`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168733598
**[Test build #48667 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48667/consoleFull)**
for PR 10541 at commit
[`1d5dd3b`](https://gi
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168729284
According to local testing result, now 75% query plans in
`HiveCompatibilitySuite` can be successfully converted to SQL query strings.
---
If your project is set up
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168728499
The following two test cases always fail when executed with other test
cases, but always pass when executed separately:
- `HiveCompatibilitySuite.select_as_om
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168713552
**[Test build #48665 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48665/consoleFull)**
for PR 10541 at commit
[`70af178`](https://gi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48739252
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48738778
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanSQLGenerationSuite.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apach
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168702388
Hm, seems that my last fixes introduced bug related to UDF handling.
Looking into it.
---
If your project is set up for it, you can reply to this email and have your
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48739082
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48738171
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanSQLGenerationSuite.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apach
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48737999
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -333,6 +333,39 @@ object ProjectCollapsing extends Ru
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48737118
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48736586
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168684647
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168684642
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168684434
**[Test build #48660 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48660/consoleFull)**
for PR 10541 at commit
[`4963676`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168676148
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168676146
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168676004
**[Test build #48657 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48657/consoleFull)**
for PR 10541 at commit
[`ef5dac2`](https://g
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48728134
--- Diff:
sql/hive/src/main/antlr3/org/apache/spark/sql/parser/SparkSqlParser.g ---
@@ -637,7 +637,7 @@ import org.apache.hadoop.hive.conf.HiveConf;
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48728103
--- Diff:
sql/hive/src/main/antlr3/org/apache/spark/sql/parser/SparkSqlParser.g ---
@@ -637,7 +637,7 @@ import org.apache.hadoop.hive.conf.HiveConf;
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48727799
--- Diff:
sql/hive/src/main/antlr3/org/apache/spark/sql/parser/SparkSqlParser.g ---
@@ -637,7 +637,7 @@ import org.apache.hadoop.hive.conf.HiveConf;
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168670159
**[Test build #48660 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48660/consoleFull)**
for PR 10541 at commit
[`4963676`](https://gi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10541#discussion_r48727289
--- Diff:
sql/hive/src/main/antlr3/org/apache/spark/sql/parser/SparkSqlParser.g ---
@@ -637,7 +637,7 @@ import org.apache.hadoop.hive.conf.HiveConf;
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168669586
@rxin Thanks for helping explaining this.
@hvanhovell Would also like to add that, once fully implemented, SQL
statement generation itself can be quite useful
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-168659455
**[Test build #48657 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48657/consoleFull)**
for PR 10541 at commit
[`ef5dac2`](https://gi
70 matches
Mail list logo
