Github user vijaykiran commented on the pull request:
https://github.com/apache/spark/pull/10598#issuecomment-169275901
@BryanCutler Thanks for the review, I added a new commit - will review
update other two PRs with 100 fill-column as well.
---
If your project is set up for it,
GitHub user vijaykiran opened a pull request:
https://github.com/apache/spark/pull/10598
[SPARK-12630][DOC] Update param descriptions
Updates the `param` descriptions consistent. See [SPARK-11219] for more
details.
You can merge this pull request into a Git repository by
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48886110
--- Diff: python/pyspark/mllib/classification.py ---
@@ -323,38 +330,45 @@ def train(cls, data, iterations=100,
initialWeights=None, regParam=0.01,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48886211
--- Diff: python/pyspark/mllib/classification.py ---
@@ -490,37 +506,45 @@ def train(cls, data, iterations=100, step=1.0,
regParam=0.01,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48887425
--- Diff: python/pyspark/mllib/classification.py ---
@@ -323,38 +330,45 @@ def train(cls, data, iterations=100,
initialWeights=None, regParam=0.01,
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10598#issuecomment-169110387
thanks @vijaykiran! I marked a few things for correction and I think in
general we should extend the comments to the 100 character limit where
applicable.
---
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48887470
--- Diff: python/pyspark/mllib/classification.py ---
@@ -323,38 +330,45 @@ def train(cls, data, iterations=100,
initialWeights=None, regParam=0.01,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48886805
--- Diff: python/pyspark/mllib/classification.py ---
@@ -272,37 +274,42 @@ def train(cls, data, iterations=100, step=1.0,
miniBatchFraction=1.0,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10598#issuecomment-168968321
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48912976
--- Diff: python/pyspark/mllib/classification.py ---
@@ -323,38 +330,45 @@ def train(cls, data, iterations=100,
initialWeights=None, regParam=0.01,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48913054
--- Diff: python/pyspark/mllib/classification.py ---
@@ -94,16 +94,18 @@ class
LogisticRegressionModel(LinearClassificationModel):
11 matches
Mail list logo