Github user somideshmukh closed the pull request at:
https://github.com/apache/spark/pull/10602
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user somideshmukh closed the pull request at:
https://github.com/apache/spark/pull/10897
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10602#issuecomment-183471455
Thanks for working on this @somideshmukh , I finished up the remaining work
in https://github.com/apache/spark/pull/11186. Could you please close this PR
and the
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10897#issuecomment-183142126
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10897#issuecomment-183145980
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10897#issuecomment-183145979
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10602#issuecomment-181506578
Hi @somideshmukh , any update for this? Let me know if you need any
assistance.
---
If your project is set up for it, you can reply to this email and have your
GitHub user somideshmukh opened a pull request:
https://github.com/apache/spark/pull/10897
[SPARK-12632][Python][Make Parameter Descriptions Consistent for PySpark
MLlib FPM and Recommendation]
made changes according to indentation setting done in intellji
You can merge this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10897#issuecomment-174483498
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10602#issuecomment-174011424
Hi @somideshmukh , it looks like your changes still have a couple of
indentation problems. Maybe try changing the indent to not use the tab
character. If using
Github user somideshmukh commented on the pull request:
https://github.com/apache/spark/pull/10602#issuecomment-171915841
We have made same changes and committed the code,but when pull request is
created ,it i showing indentation problem.I am attaching image will show
changes we
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r49795026
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -67,12 +67,14 @@ class FPGrowth(object):
def train(cls, data, minSupport=0.3, numPartitions=-1):
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r49795192
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -128,17 +130,25 @@ class PrefixSpan(object):
@since("1.6.0")
def train(cls, data,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r49795250
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -128,17 +130,25 @@ class PrefixSpan(object):
@since("1.6.0")
def train(cls, data,
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10602#issuecomment-170159780
I just added a note to the parent JIRA about a formatting issue affecting
all 5 PRs:
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r49140273
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -130,15 +133,21 @@ def train(cls, data, minSupport=0.1,
maxPatternLength=10, maxLocalProjDBSize=320
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r49140295
--- Diff: python/pyspark/mllib/recommendation.py ---
@@ -239,6 +239,17 @@ def train(cls, ratings, rank, iterations=5,
lambda_=0.01, blocks=-1, nonnegative
Github user vijaykiran commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r48945561
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -67,12 +67,15 @@ class FPGrowth(object):
def train(cls, data, minSupport=0.3, numPartitions=-1):
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r48916985
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -130,15 +133,22 @@ def train(cls, data, minSupport=0.1,
maxPatternLength=10, maxLocalProjDBSize=320
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r48917047
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -68,11 +68,14 @@ def train(cls, data, minSupport=0.3, numPartitions=-1):
"""
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r48917244
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -130,15 +133,22 @@ def train(cls, data, minSupport=0.1,
maxPatternLength=10, maxLocalProjDBSize=320
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r48917505
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -68,11 +68,14 @@ def train(cls, data, minSupport=0.3, numPartitions=-1):
"""
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10602#issuecomment-16918
Thanks @somideshmukh! Could you please look the corrections from
@vijaykiran and me, extend the descriptions to the 100 character limit, and add
the parameter
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10602#issuecomment-168986043
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vijaykiran commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r48839934
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -130,15 +133,22 @@ def train(cls, data, minSupport=0.1,
maxPatternLength=10, maxLocalProjDBSize=320
Github user vijaykiran commented on a diff in the pull request:
https://github.com/apache/spark/pull/10602#discussion_r48839858
--- Diff: python/pyspark/mllib/fpm.py ---
@@ -68,11 +68,14 @@ def train(cls, data, minSupport=0.3, numPartitions=-1):
"""
GitHub user somideshmukh opened a pull request:
https://github.com/apache/spark/pull/10602
[SPARK-12632][Python][Make Parameter Descriptions Consistent for PySpark
MLlib FPM and Recommendation]
Made changes in FPM file ,Recommendation file doesnot contain param changes
You can
27 matches
Mail list logo
