Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11787
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198197803
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
GitHub user yy2016 opened a pull request:
https://github.com/apache/spark/pull/11798
[SPARK-12719][HOTFIX] Fix compilation against Scala 2.10
## What changes were proposed in this pull request?
Compilation against Scala 2.10 fails with:
```
[error] [warn]
/h
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-198138864
@yy2016 `OneRowRelation` is an object rather than a class, and should be
matched using `case OneRowRelation =>`.
---
If your project is set up for it, you can reply
Github user yy2016 closed the pull request at:
https://github.com/apache/spark/pull/11795
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-197977494
Thanks. I am merging this to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198142719
**[Test build #53485 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53485/consoleFull)**
for PR 11798 at commit
[`a5403b1`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198108714
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user yy2016 commented on the pull request:
https://github.com/apache/spark/pull/11795#issuecomment-198100608
@yhuai
How about this change ?
```
diff --git a/pom.xml b/pom.xml
index 92a32e7..bdb0408 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1800,6 +1800,7
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11798
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yy2016 commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-197974831
bq. Why not just increase the pattern match analysis budget
There is a chance the new budget gets exceeded in the future when more
cases are added.
---
If your
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198198220
@JoshRosen It seems that tuning `scalac.patmat.analysisBudget` doesn't work
for this case. According to [Scala compiler code][1],
`-Dscalac.patmat.analysisBudget=off`
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198170654
**[Test build #53493 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53493/consoleFull)**
for PR 11798 at commit
[`bd37dcf`](https://gi
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-198012456
Just reverted it because it breaks the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user yy2016 commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198168990
See if this is good.
I can modify the description when I get confirmation.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-197966473
Why not just increase the pattern match analysis budget?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198201906
@yy2016 Updated commit message:
> PR #11696 introduced a complex pattern match that broke Scala 2.10 match
unreachability check and caused build failure. This
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198168724
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198142164
Note that the PR builder won't actually test this against 2.10, so we'll
still need to check this out and test it ourselves before merge.
---
If your project is set
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11795#issuecomment-198088448
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user yy2016 opened a pull request:
https://github.com/apache/spark/pull/11787
[SPARK-12719][HOTFIX] Fix compilation against Scala 2.10
## What changes were proposed in this pull request?
Compilation against Scala 2.10 fails with:
```
[error] [warn]
/home/jenk
Github user yy2016 commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-197974455
This was the first build which failed:
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/SPARK-master-COMPILE-sbt-SCALA-2.10/500/
There wa
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11795#issuecomment-198101480
Only the SBT 2.10 builder is failing, so the fix should go into
SparkBuild.scala
---
If your project is set up for it, you can reply to this email and have your
repl
Github user yy2016 commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198111545
@JoshRosen
See if this is better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198168494
**[Test build #53492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53492/consoleFull)**
for PR 11798 at commit
[`f13abe8`](https://gi
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198166015
I tested locally. Unfortunately, it did not fix the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198168495
**[Test build #53485 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53485/consoleFull)**
for PR 11798 at commit
[`a5403b1`](https://g
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-197964924
You are using wrong JIRA number.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198168727
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198209396
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user yy2016 commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-198144256
@liancheng
What's your preference ?
@JoshRosen suggested defining Dscalac.patmat.analysisBudget
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198208978
**[Test build #53492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53492/consoleFull)**
for PR 11798 at commit
[`f13abe8`](https://g
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11795#issuecomment-198089197
Can you take a look at the patmatch budget of scala 2.11? Then, let's
increase that for 2.10 build accordingly.
---
If your project is set up for it, you can reply to th
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-198153350
I agree with @JoshRosen. Was just answering your question above :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198111929
Why not pass it to `scalacOptions` instead of setting a system property?
https://github.com/yy2016/spark/blob/master/project/SparkBuild.scala#L194
---
If your projec
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198162748
let me test this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11795#issuecomment-198088925
-1. This seems like a hacky fix compared to either bumping the analysis
budget in the 2.10 compiler config or to a properly rewritten + expanded
pattern match.
---
Github user yy2016 commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-198053603
I wonder why OneRowRelation isn't covered by the following import ?
```
import org.apache.spark.sql.catalyst.plans.logical._
```
---
If your project is set u
GitHub user yy2016 opened a pull request:
https://github.com/apache/spark/pull/11795
[SPARK-12719][HOTFIX] Fix compilation against Scala 2.10
## What changes were proposed in this pull request?
Compilation against Scala 2.10 fails with:
```
[error] [warn]
/h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198197805
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198209401
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198197372
**[Test build #53493 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53493/consoleFull)**
for PR 11798 at commit
[`bd37dcf`](https://g
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11798#issuecomment-198141920
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11787#issuecomment-197962123
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
44 matches
Mail list logo
