[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10968 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176394780 I'm going to merge this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176358419 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176357192 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176357187 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176356482 **[Test build #50283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50283/consoleFull)** for PR 10968 at commit [`463f68a`](https://g

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176347265 **[Test build #2468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2468/consoleFull)** for PR 10968 at commit [`03ea283`](https://

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176314290 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176314889 **[Test build #50283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50283/consoleFull)** for PR 10968 at commit [`463f68a`](https://gi

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176314296 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176306162 Just reverted all accidental formatting changes made by IntelliJ. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176306010 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176305245 **[Test build #2468 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2468/consoleFull)** for PR 10968 at commit [`03ea283`](https://g

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176304119 @rxin Updated, thanks for the review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176080460 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176080459 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176080241 **[Test build #50266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50266/consoleFull)** for PR 10968 at commit [`4ad74c0`](https://g

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10968#issuecomment-176046912 **[Test build #50266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50266/consoleFull)** for PR 10968 at commit [`4ad74c0`](https://gi

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10968#discussion_r51090555 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala --- @@ -374,21 +366,27 @@ final class DataFrameStatFunctions private[sql](df

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10968#discussion_r51090456 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketch.java --- @@ -124,6 +124,18 @@ int getVersionNumber() { */ publi

[GitHub] spark pull request: [SPARK-12818][SQL] Specialized integral and st...

2016-01-27 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/10968 [SPARK-12818][SQL] Specialized integral and string types for Count-min Sketch This PR is a follow-up of #10911. It adds specialized update methods for `CountMinSketch` so that we can avoid doing