[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176951432 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176951429 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176943645 Thanks for the review, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/10985#discussion_r51308254 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java --- @@ -68,14 +65,14 @@ int getVersionNumber() { }

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176941082 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176941077 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176940538 **[Test build #50399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50399/consoleFull)** for PR 10985 at commit [`605b011`](https://g

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176937287 LGTM, thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10985#discussion_r51306157 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java --- @@ -68,14 +65,14 @@ int getVersionNumber() { }

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176934152 **[Test build #50399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50399/consoleFull)** for PR 10985 at commit [`605b011`](https://gi

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176933754 LGTM. @cloud-fan should review too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176933324 cc @cloud-fan @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10985#issuecomment-176930921 Also went through generated Javadoc to fix all visibility and style issues. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-12818] Polishes spark-sketch module

GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/10985 [SPARK-12818] Polishes spark-sketch module You can merge this pull request into a Git repository by running: $ git pull https://github.com/liancheng/spark sketch-polishing Alternatively yo