Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10839
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-210222663
Sorry for late response! This LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user Fokko commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-201822435
@mengxr did you had a chance to look at the updated version? I also
extended the test to check the conversion to dense/sparse vectors.
---
If your project is set up for
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-199537721
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-199537720
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-199537586
**[Test build #53722 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53722/consoleFull)**
for PR 10839 at commit
[`25c5f66`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-199523568
**[Test build #53722 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53722/consoleFull)**
for PR 10839 at commit
[`25c5f66`](https://gi
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-199504808
Btw, you also need to merge with the current master to resolve conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10839#discussion_r56881462
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -263,13 +263,33 @@ class BlockMatrix @Since("1.3.0") (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10839#discussion_r56881322
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -263,13 +263,33 @@ class BlockMatrix @Since("1.3.0") (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10839#discussion_r56881327
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -263,13 +263,33 @@ class BlockMatrix @Since("1.3.0") (
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197743784
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197743430
**[Test build #53401 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53401/consoleFull)**
for PR 10839 at commit
[`c043e77`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197826121
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197826124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197557655
@Fokko That PR was merged. Could you merge the current master and update
your implementation? Note that when you concat the vectors, it is useful to
check the sparsity a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197734670
**[Test build #53401 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53401/consoleFull)**
for PR 10839 at commit
[`c043e77`](https://gi
Github user Fokko commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-198545136
@mengxr I've updated the code according to your PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197808378
**[Test build #53419 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53419/consoleFull)**
for PR 10839 at commit
[`d3c780d`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197743788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197825796
**[Test build #53419 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53419/consoleFull)**
for PR 10839 at commit
[`d3c780d`](https://g
Github user Fokko commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197222971
Nice work, as soon as the PR will be merged I will update the code
accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197188227
@Fokko The implementation doesn't take care of sparsity yet. I created
https://github.com/apache/spark/pull/11757 to add row/column iterators to local
matrices. After th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197102995
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197102997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197102500
**[Test build #53240 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53240/consoleFull)**
for PR 10839 at commit
[`fe1842e`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197092355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197092354
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197092168
**[Test build #53238 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53238/consoleFull)**
for PR 10839 at commit
[`ba7791f`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197063693
**[Test build #53240 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53240/consoleFull)**
for PR 10839 at commit
[`fe1842e`](https://gi
Github user Fokko commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197063381
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197059527
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197059514
**[Test build #53239 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53239/consoleFull)**
for PR 10839 at commit
[`a9bc894`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197059524
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197057478
**[Test build #53239 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53239/consoleFull)**
for PR 10839 at commit
[`a9bc894`](https://gi
Github user Fokko commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197057413
I've improved the PR based on the feedback. Beside that I've also updated
the benchmark:
https://github.com/Fokko/BlockMatrixToIndexedRowMatrix
If there are a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197056403
**[Test build #53238 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53238/consoleFull)**
for PR 10839 at commit
[`ba7791f`](https://gi
Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/10839#discussion_r56143177
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -268,8 +268,26 @@ class BlockMatrix @Since("1.3.0") (
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10839#discussion_r56062757
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -268,8 +268,26 @@ class BlockMatrix @Since("1.3.0") (
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-196022452
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-196022449
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-196022345
**[Test build #53036 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53036/consoleFull)**
for PR 10839 at commit
[`67fd902`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-196016183
**[Test build #53036 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53036/consoleFull)**
for PR 10839 at commit
[`67fd902`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-189485546
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-189485549
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-189485538
**[Test build #52080 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52080/consoleFull)**
for PR 10839 at commit
[`4d7c297`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-189485124
**[Test build #52080 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52080/consoleFull)**
for PR 10839 at commit
[`4d7c297`](https://gi
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-189483885
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-187695587
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-183938661
cc @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-173000964
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user Fokko opened a pull request:
https://github.com/apache/spark/pull/10839
[SPARK-12869] Implemented an improved version of the toIndexedRowMatrix
Hi guys,
I've implemented an improved version of the `toIndexedRowMatrix` function
on the `BlockMatrix`. I needed this
52 matches
Mail list logo
