Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11932
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-201143595
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-201122172
**[Test build #54139 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54139/consoleFull)**
for PR 11932 at commit
[`9023a92`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-201122246
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-201122243
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-201116421
**[Test build #54139 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54139/consoleFull)**
for PR 11932 at commit
[`9023a92`](https://gi
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-201066270
@felixcheung It works without `survival::` because `survreg` is a regular
function, like `glm`. If it is an S3 generic method like `naiveBayes`, we have
to use the names
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200944842
Right - it's nice to see if we have similar interface.
This
[test](https://github.com/apache/spark/pull/11932/files#diff-51c07c6af7649f6c021e5a5438e31a4fR24
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200936989
@yanboliang The implementation looks good to me. Please update the PR and
remove the `survreg2` test.
---
If your project is set up for it, you can reply to this email
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11932#discussion_r57319437
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -200,3 +200,73 @@ test_that("naiveBayes", {
expect_equal(as.character(predict(m, t1[1, ]))
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11932#discussion_r57318372
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -200,3 +200,73 @@ test_that("naiveBayes", {
expect_equal(as.character(predict(m, t1[1, ]))
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200838277
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200838271
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200837946
**[Test build #54038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54038/consoleFull)**
for PR 11932 at commit
[`dc64aaa`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200820507
**[Test build #54038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54038/consoleFull)**
for PR 11932 at commit
[`dc64aaa`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200796555
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200796554
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200796515
**[Test build #54031 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54031/consoleFull)**
for PR 11932 at commit
[`e6cc821`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11932#issuecomment-200783017
**[Test build #54031 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54031/consoleFull)**
for PR 11932 at commit
[`e6cc821`](https://gi
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-200782503
Let move to #11932
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/11447
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11932
[SPARK-13010] [ML] [SparkR] Implement a simple wrapper of
AFTSurvivalRegression in SparkR
## What changes were proposed in this pull request?
This PR continues the work in #11447, we impleme
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57298823
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,24 @@ test_that("kmeans", {
cluster <- summary.model$cluster
expect_equal
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57260615
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,24 @@ test_that("kmeans", {
cluster <- summary.model$cluster
expect_equa
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-200281017
@mengxr OK, I will update this PR following #11890 . Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57134594
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,24 @@ test_that("kmeans", {
cluster <- summary.model$cluster
expect_equal
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-199957859
@yanboliang I did some factoring of `naiveBayes` implementation in
https://github.com/apache/spark/pull/11890. I feel it makes the code less
coupled if we have separate
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57044768
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -52,6 +53,43 @@ private[r] object SparkRWrappers {
pipeline.fit(df)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57044614
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -52,6 +53,43 @@ private[r] object SparkRWrappers {
pipeline.fit(df)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57044260
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -52,6 +53,43 @@ private[r] object SparkRWrappers {
pipeline.fit(df)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57044239
--- Diff: R/pkg/R/mllib.R ---
@@ -61,6 +61,34 @@ setMethod("glm", signature(formula = "formula", family =
"ANY", data = "DataFram
return(new(
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57042682
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,24 @@ test_that("kmeans", {
cluster <- summary.model$cluster
expect_equal(sor
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57042693
--- Diff: R/pkg/R/mllib.R ---
@@ -61,6 +61,34 @@ setMethod("glm", signature(formula = "formula", family =
"ANY", data = "DataFram
return(new(
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r57042684
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,24 @@ test_that("kmeans", {
cluster <- summary.model$cluster
expect_equal(sor
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197883529
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197883530
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197882401
**[Test build #53431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53431/consoleFull)**
for PR 11447 at commit
[`7aabd2e`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-198311084
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-198295293
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197925458
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-198293656
**[Test build #53528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53528/consoleFull)**
for PR 11447 at commit
[`2a9893b`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197883525
**[Test build #53431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53431/consoleFull)**
for PR 11447 at commit
[`7aabd2e`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197899505
**[Test build #53433 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53433/consoleFull)**
for PR 11447 at commit
[`ba01668`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-198295284
**[Test build #53528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53528/consoleFull)**
for PR 11447 at commit
[`2a9893b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-198311079
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197925244
**[Test build #53434 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53434/consoleFull)**
for PR 11447 at commit
[`267e75d`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197925454
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197898514
**[Test build #53433 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53433/consoleFull)**
for PR 11447 at commit
[`ba01668`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-198295298
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-198310810
**[Test build #53530 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53530/consoleFull)**
for PR 11447 at commit
[`900c85f`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197902127
**[Test build #53434 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53434/consoleFull)**
for PR 11447 at commit
[`267e75d`](https://gi
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-198232096
@hhbyyh @mengxr
```survival::survreg``` and ```SparkR::survreg``` share the same first
argument type (formula). So I don't think we can avoid shadowing the metho
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197899514
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-197899512
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-198298576
**[Test build #53530 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53530/consoleFull)**
for PR 11447 at commit
[`900c85f`](https://gi
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r55134020
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala
---
@@ -376,6 +400,23 @@ object AFTSurvivalRegressionModel extends
Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-192601945
only some minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r55117224
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,17 @@ test_that("kmeans", {
cluster <- summary.model$cluster
expect_equal(sor
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r55117106
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -52,6 +53,43 @@ private[r] object SparkRWrappers {
pipeline.fit(df)
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-192541868
Please check out
[this](https://github.com/apache/spark/blob/master/R/pkg/inst/tests/testthat/test_context.R#L22)
test - you could `library(survival)` and then exec
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-192344562
@yanboliang The `glm` interface won't shadow `stat::glm`. Could you check
the implementation there? This might be relevant:
https://github.com/apache/spark/pull/9582.
Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-192215491
Thanks. I'll make a pass more closely tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-192209916
@hhbyyh Thanks for your review.
I have also encountered this issue, because our ```survreg``` was masked by
```survreg``` in survival package under this conditio
Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-192206404
@yanboliang I tried your implementation with
```
library(survival)
data(ovarian)
df <- createDataFrame(sqlContext, ovarian)
model <- survreg(Surv(f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-191193476
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-191193479
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-191193347
**[Test build #52314 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52314/consoleFull)**
for PR 11447 at commit
[`e149bd8`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-191175536
**[Test build #52314 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52314/consoleFull)**
for PR 11447 at commit
[`e149bd8`](https://gi
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-190830323
@hhbyyh Could you help review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-190766589
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-190766600
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-190765979
**[Test build #52246 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52246/consoleFull)**
for PR 11447 at commit
[`7849fd0`](https://g
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r54576966
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -52,6 +53,43 @@ private[r] object SparkRWrappers {
pipeline.fit(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r54576046
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -52,6 +53,43 @@ private[r] object SparkRWrappers {
pipeline.fit(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r54574911
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,17 @@ test_that("kmeans", {
cluster <- summary.model$cluster
expect_equal
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r54574478
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,17 @@ test_that("kmeans", {
cluster <- summary.model$cluster
expect_equal
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11447
[SPARK-13010] [ML] [SparkR] Implement a simple wrapper of
AFTSurvivalRegression in SparkR
## What changes were proposed in this pull request?
Implement a simple wrapper of ```AFTSurvivalRegr
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11447#discussion_r54573876
--- Diff: R/pkg/R/mllib.R ---
@@ -61,6 +61,34 @@ setMethod("glm", signature(formula = "formula", family =
"ANY", data = "DataFram
return(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11447#issuecomment-190742935
**[Test build #52246 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52246/consoleFull)**
for PR 11447 at commit
[`7849fd0`](https://gi
79 matches
Mail list logo
