Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10977
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176675120
I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176663786
**[Test build #2473 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2473/consoleFull)**
for PR 10977 at commit
[`ffa8e6b`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176642840
**[Test build #50359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50359/consoleFull)**
for PR 10977 at commit
[`ffa8e6b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176643027
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176643022
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176638543
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176638542
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176636537
**[Test build #50359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50359/consoleFull)**
for PR 10977 at commit
[`ffa8e6b`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176636705
**[Test build #2473 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2473/consoleFull)**
for PR 10977 at commit
[`ffa8e6b`](https://g
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176635918
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176635007
@rxin Added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176620545
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176620544
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176620367
**[Test build #50351 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50351/consoleFull)**
for PR 10977 at commit
[`951e2cd`](https://g
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176619981
The issue here is that we want test cases that are targeted for specific
problems, and the Hive ones are not (they are just a giant blackbox we took to
bootstrap coverage)
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176619523
Sure it's a good idea to use that golden file infrastructure. Given we
don't have that yet, can you just add a test case?
---
If your project is set up for it, you
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176618967
The way we managed HiveCompatibilitySuite is actually better than our unit
tests (sql query and golden results in text format). Even if we don't want to
be compatible wi
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176609355
Thanks - can you add a test case that would catch this? In the long run, we
don't want to rely on HiveCompatibilitySuite.
---
If your project is set up for it, you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176601896
**[Test build #50351 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50351/consoleFull)**
for PR 10977 at commit
[`951e2cd`](https://gi
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176601291
When there is no aggregate functions, it did not generate the output using
resultExpression, which have only literals (I was mislead by the comment in
AggregateIterator)
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10977#issuecomment-176600324
What's the bug?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/10977
[SPARK-13031] [SQL] cleanup codegen and improve test coverage
1. enable whole stage codegen during tests even there is only one operator
supports that.
2. split doProduce() into two APIs: upstre
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10944#discussion_r51193081
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -42,10 +44,16 @@ trait CodegenSupport extends SparkPlan {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10944
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-176437234
Thanks, merging this into master to unblock others, comments will be
addressed by follow up.
---
If your project is set up for it, you can reply to this email and have
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10944#discussion_r51193347
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -172,38 +184,42 @@ case class Range(
s"$number > $part
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-176333057
The generated code has a ton of extra new lines. If this is easy to remove,
it will help the debuggability of this.
LGTM, feel free to address the comments in fo
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10944#discussion_r51166689
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -42,10 +44,16 @@ trait CodegenSupport extends SparkPlan {
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10944#discussion_r51166567
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -172,38 +184,42 @@ case class Range(
s"$number > $part
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10944#discussion_r51166249
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -162,37 +206,48 @@ case class InputAdapter(child: SparkPlan)
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-176013043
@nongli Does this one looks good to you? this one blocks others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-175895315
Here is the generated code for `sqlContext.range(values).filter("(id & 1) =
1").count()`
```
/* 001 */
/* 002 */ public Object generate(Object[] referenc
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-175892206
Can you paste some generated code? (Actually I think that's useful for most
of the code gen prs).
---
If your project is set up for it, you can reply to this email and ha
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-175885463
cc @nongli @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-175512911
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-175512913
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-175512703
**[Test build #50183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50183/consoleFull)**
for PR 10944 at commit
[`b4db006`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10944#issuecomment-175478481
**[Test build #50183 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50183/consoleFull)**
for PR 10944 at commit
[`b4db006`](https://gi
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/10944
[SPARK-13031] [SQL] cleanup codegen and improve test coverage
1. enable whole stage codegen during tests even there is only one operator
supports that.
2. split doProduce() into two APIs: upstre
40 matches
Mail list logo
