Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11000
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-189117008
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188217429
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188217094
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188217276
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188216762
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188198030
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188197909
**[Test build #51873 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51873/consoleFull)**
for PR 11000 at commit
[`3646b36`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188198033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188191406
**[Test build #51873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51873/consoleFull)**
for PR 11000 at commit
[`3646b36`](https://gi
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-188189795
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Wenpei commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-18721
@mengxr @srowen Can you add me to white list ? or help to launch a jenkins
test for this?
---
If your project is set up for it, you can reply to this email and have you
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11000#discussion_r53635317
--- Diff: python/pyspark/ml/regression.py ---
@@ -172,6 +172,16 @@ class IsotonicRegression(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredicti
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11000#discussion_r53635702
--- Diff: python/pyspark/ml/regression.py ---
@@ -690,6 +700,18 @@ class AFTSurvivalRegression(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-187221567
Looks good except minor issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-187222806
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user Wenpei commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-187047801
@yanboliang I complete this pr, please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user Wenpei commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-184131612
@yanboliang OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-184118656
@Wenpei Please pay attention to the status of #11197 and update this PR
corresponding when it get merged.
---
If your project is set up for it, you can reply to thi
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11000#discussion_r52872250
--- Diff: python/pyspark/ml/regression.py ---
@@ -697,6 +714,25 @@ class AFTSurvivalRegression(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11000#discussion_r52871887
--- Diff: python/pyspark/ml/regression.py ---
@@ -179,6 +179,23 @@ class IsotonicRegression(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredicti
Github user Wenpei commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-184090963
@yanboliang @mengxr
Done for this PR. Please help review and launch test.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user Wenpei commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-178975120
I need do a minor change for this PR after 13153 get resoved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user Wenpei commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-178970906
Sure, good catch. I have submit a jira 13153 and submit a pr later
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-178966434
It should not make all parameters have default value because of some params
are not setting default value on purpose. I think we should modify
```_transfer_params_fr
Github user Wenpei commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-178953997
Sure, I will submit a jira, I thought we need fix it in scala side that
ensure all parameter has default value.
---
If your project is set up for it, you can reply to t
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-178575141
@Wenpei It looks like ```_transfer_params_from_java``` did not consider the
params which do not have default value and we should handle them. Would you
mind to creat
Github user Wenpei commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-178381846
@yanboliang Sorry for last PR that I didn't check scala side.
For regression, there are only three algorithm support MLRead/MLWrite:
LinearRegression
Isot
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/11000#discussion_r51400507
--- Diff: python/pyspark/ml/regression.py ---
@@ -447,7 +447,7 @@ def _create_model(self, java_model):
@inherit_doc
-class DecisionTre
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11000#issuecomment-177855644
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user Wenpei opened a pull request:
https://github.com/apache/spark/pull/11000
[SPARK-13033][ML][PySpark] Add import/export for ml.regression
Add export/import for all estimators and transformers(which have Scala
implementation) under pyspark/ml/regression.py.
@yanbol
31 matches
Mail list logo
