Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10976
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-184509207
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183989996
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183989997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183980352
**[Test build #51278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51278/consoleFull)**
for PR 10976 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183989945
**[Test build #51278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51278/consoleFull)**
for PR 10976 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183845600
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183857817
**[Test build #51261 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51261/consoleFull)**
for PR 10976 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183846482
**[Test build #51255 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51255/consoleFull)**
for PR 10976 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183846485
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183846484
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10976#discussion_r52840380
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Binarizer.scala
---
@@ -62,28 +65,54 @@ final class Binarizer(override val uid: String)
def
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183846389
**[Test build #51255 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51255/consoleFull)**
for PR 10976 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183864188
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183864185
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183863932
**[Test build #51261 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51261/consoleFull)**
for PR 10976 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183864977
LGTM, besides a minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183509463
LGTM pending Jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user seddonm1 commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183506233
Thanks @mengxr.
I have updated the pull request with your suggestions. I believe that we
still need to use the .compressed even after moving the `if (value >
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183510131
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183513537
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183511485
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183513536
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183513531
**[Test build #51209 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51209/consoleFull)**
for PR 10976 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183510130
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183519585
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183519588
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183513314
**[Test build #51209 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51209/consoleFull)**
for PR 10976 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183138299
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10976#discussion_r52694925
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Binarizer.scala
---
@@ -62,28 +65,57 @@ final class Binarizer(override val uid: String)
def
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10976#discussion_r52694924
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Binarizer.scala
---
@@ -62,28 +65,57 @@ final class Binarizer(override val uid: String)
def
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183142437
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183117786
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183121590
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183121594
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10976#discussion_r52694928
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Binarizer.scala
---
@@ -62,28 +65,57 @@ final class Binarizer(override val uid: String)
def
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183140914
Some minor comments. Overall it looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10976#discussion_r52694965
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/BinarizerSuite.scala ---
@@ -22,6 +22,7 @@ import org.apache.spark.ml.param.ParamsSuite
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10976#issuecomment-183142439
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
39 matches
Mail list logo
