Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12078
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-206515076
I submitted #12211 to make sure RegisterExecutorResponse arrive before
LaunchTask so that we don't need to worry about if it's safe to create Executor
before
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12078#discussion_r58617810
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -41,7 +41,8 @@ private[spark] class
Github user XuTingjun commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-205684324
Can I ask a question, why can't initialize executor before register to
driver as this pr? Is there any hidden danger?
---
If your project is set up for it, you can
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-204329728
I see your point, just defer the registering of executors until fully
created. But here Spark do take care of this issue by such code, though as I
said not so
Github user viper-kun commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-204322877
I don't think so. It is a wrong order "after registed to drive first, it
begin new Executor.
---
If your project is set up for it, you can reply to this email and
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-204273968
I think current Spark code already do care about this race condition issue,
though not so elegant. From the description of JIRA, I think a more broad
problem is how
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-204144114
The race condition does exist. Let me think about if there is a better way
to fix it.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-203773443
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-203773436
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-203772900
**[Test build #54586 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54586/consoleFull)**
for PR 12078 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-203744495
**[Test build #54586 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54586/consoleFull)**
for PR 12078 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-203744234
add to whitelist @zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12078#issuecomment-203726024
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user viper-kun opened a pull request:
https://github.com/apache/spark/pull/12078
[SPARK-13112]CoarsedExecutorBackend register to driver should wait Executor
was ready
## What changes were proposed in this pull request?
When CoarseGrainedExecutorBackend receives
15 matches
Mail list logo
