Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-193722345
OK. Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-193539323
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-193462061
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-193462067
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-193460383
**[Test build #52576 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52576/consoleFull)**
for PR 11490 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-193389883
**[Test build #52576 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52576/consoleFull)**
for PR 11490 at commit
Github user devaraj-kavali commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-193282292
Sounds fine @srowen, I will update with the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-193236703
Hm, maybe we should log both pieces of information. It currently logs
_some_ public host name that the UI has bound to, which is good. but maybe the
message can include
Github user devaraj-kavali commented on a diff in the pull request:
https://github.com/apache/spark/pull/11490#discussion_r5519
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -134,7 +134,8 @@ private[spark] abstract class WebUI(
def bind() {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11490#discussion_r55189207
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -134,7 +134,8 @@ private[spark] abstract class WebUI(
def bind() {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192892954
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192892948
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192892622
**[Test build #52528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52528/consoleFull)**
for PR 11490 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192878629
**[Test build #52528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52528/consoleFull)**
for PR 11490 at commit
Github user devaraj-kavali commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192878456
Thanks @srowen and @zsxwing for the confirmation. I have updated the
description and fixed the review comment.
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192503297
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192503294
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192502738
**[Test build #52484 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52484/consoleFull)**
for PR 11490 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11490#discussion_r55082251
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -134,7 +134,8 @@ private[spark] abstract class WebUI(
def bind() {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192444626
**[Test build #52484 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52484/consoleFull)**
for PR 11490 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192443525
@devaraj-kavali could you update the PR description?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192443319
Sounds great. If the user sets `SPARK_LOCAL_IP` to a real ip, he should be
aware of his settings and know he cannot use `localhost` or `127.0.0.1` to
access the UI.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192442599
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192218924
@zsxwing what do you think of this? it looks right-er. I'm trying to think
through the implications here. Certainly, behavior doesn't change unless
`SPARK_LOCAL_IP` is
Github user devaraj-kavali commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-192118319
I agree @srowen, I see that SPARK_PUBLIC_DNS is not for binding purpose. I
have changed the env var to SPARK_LOCAL_IP.
---
If your project is set up for it,
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-191941423
I don't know if `SPARK_PUBLIC_DNS` should be referenced, actually, on
further look. It controls what address is advertised, not how it binds.
---
If your project is
Github user devaraj-kavali commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-191869171
I had overlooked and it was my mistake, I think we need to consider both
the env variables something like,
```
serverInfo =
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-191816798
So this now only changes behavior in `SPARK_PUBLIC_DNS` is set. Is that
really the right env variable? the JIRA mentions `SPARK_LOCAL_IP` and the docs
suggest that
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11490#issuecomment-191681962
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user devaraj-kavali opened a pull request:
https://github.com/apache/spark/pull/11490
[SPARK-13117] [Web UI] WebUI should use the local ip not 0.0.0.0
## What changes were proposed in this pull request?
In WebUI, now Jetty Server starts with SPARK_PUBLIC_DNS config
31 matches
Mail list logo
