Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64462691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -100,8 +118,11 @@ private class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64449670
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -100,8 +118,11 @@ private class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64449626
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatterSuite.scala
---
@@ -36,6 +36,22 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64446968
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatterSuite.scala
---
@@ -36,6 +36,22 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64442432
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatterSuite.scala
---
@@ -36,6 +36,22 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64440872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -49,6 +49,24 @@ object CodeFormatter {
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-221344268
Thank you, @davies !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-221338736
LGTM,
Merging this into master and 2.0, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64432741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -49,6 +49,24 @@ object CodeFormatter {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64354339
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -49,6 +49,24 @@ object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64333811
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -49,6 +49,24 @@ object
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64332536
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -49,6 +49,24 @@ object CodeFormatter {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64332407
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -49,6 +49,24 @@ object CodeFormatter {
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220851707
Hi, @davies and @rxin .
Could you review this PR again when you have some time?
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220746368
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220746367
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220746249
**[Test build #59039 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59039/consoleFull)**
for PR 13192 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220740772
Hi, @davies and @rxin .
I updated the code and description again according to the current master.
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220736209
**[Test build #59039 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59039/consoleFull)**
for PR 13192 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220682262
Ya. There were a huge change. I've saw the PR before, but I didn't consider
that in this PR.
My bad. Let me think how to solve the original goal with new
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220678036
@dongjoon-hyun Maybe we could have a method Expression.genCodeWithComment()
that is used by generated projections and operators, it requires change more
places, not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r64082929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -39,6 +40,23 @@ object CodeFormatter {
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220667461
Hi, @davies .
It's ready for review, again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220667027
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220667029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220666706
**[Test build #59005 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59005/consoleFull)**
for PR 13192 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220644473
**[Test build #59005 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59005/consoleFull)**
for PR 13192 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220642836
The PySpark failure is fixed as a HOTFIX.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220563590
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220563593
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220563440
**[Test build #58971 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58971/consoleFull)**
for PR 13192 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220548264
**[Test build #58971 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58971/consoleFull)**
for PR 13192 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220547752
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220544914
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220544912
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220544714
**[Test build #58960 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58960/consoleFull)**
for PR 13192 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220532622
As @rxin told, what was really needed is removing `overlapping` comments.
So, I rethink about that and revert the change on `Expression.gen` which
removes the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220531788
**[Test build #58960 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58960/consoleFull)**
for PR 13192 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r63918627
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -124,6 +124,7 @@
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r63918110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -124,6 +124,7 @@ object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r63916714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -124,6 +124,7 @@
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r63915288
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -24,13 +24,13 @@ package
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r63913511
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -124,6 +124,7 @@ object
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13192#discussion_r63913005
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -24,13 +24,13 @@ package
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220274969
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220274966
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220274764
**[Test build #58855 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58855/consoleFull)**
for PR 13192 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220272109
cc @sameeragarwal / @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220257517
Hi, @rxin .
This is the first attempt according to your request.
I removed some obsolete code in #11019 in order to pass the tests.
Please let me know
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13192#issuecomment-220256665
**[Test build #58855 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58855/consoleFull)**
for PR 13192 at commit
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/13192
[SPARK-13135][SQL] Don't print expressions recursively in generated code
## What changes were proposed in this pull request?
This PR is an up-to-date and a little bit improved
Github user rxin closed the pull request at:
https://github.com/apache/spark/pull/11019
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178765458
**[Test build #50570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50570/consoleFull)**
for PR 11019 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178765823
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178765827
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178830486
I like this output much better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178810783
**[Test build #2492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2492/consoleFull)**
for PR 11019 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178848022
**[Test build #2492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2492/consoleFull)**
for PR 11019 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178872055
**[Test build #2494 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2494/consoleFull)**
for PR 11019 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11019#discussion_r51647306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala
---
@@ -125,6 +125,7 @@ object
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178456346
**[Test build #2489 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2489/consoleFull)**
for PR 11019 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178459661
**[Test build #50554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50554/consoleFull)**
for PR 11019 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178460319
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178460324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178708459
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178722621
**[Test build #50570 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50570/consoleFull)**
for PR 11019 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178895272
**[Test build #2494 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2494/consoleFull)**
for PR 11019 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178416006
query:
```scala
sqlContext.range(1, 1000).select('id + 1 + 1).show()
```
old generated code:
```java
/* 068 */ while (!Range_overflow3 &&
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178417590
**[Test build #50551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50551/consoleFull)**
for PR 11019 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11019#discussion_r51534316
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -36,11 +36,11 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178429585
**[Test build #2489 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2489/consoleFull)**
for PR 11019 at commit
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/11019
[SPARK-13135][SQL] Don't print expressions recursively in generated code
Our code generation currently prints expressions recursively. For example,
for expression "(1 + 1) + 1)", we would print the
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178416188
Let me know if you guys think this is more clear. Alternatively, we can
also print the expression comment only for top level expressions.
---
If your project is set up
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178426154
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178426158
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178426117
**[Test build #50551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50551/consoleFull)**
for PR 11019 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178415439
New generated code:
```java
scala> sqlContext.range(1, 1000).agg(expr("count(1)"),
expr("sum(id)")).show()
/* 001 */
/* 002 */ public Object
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178428368
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178428206
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11019#issuecomment-178431864
**[Test build #50554 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50554/consoleFull)**
for PR 11019 at commit
81 matches
Mail list logo
