Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11067
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181763572
merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181267861
Yah @tedyu has a follow up PR that adds the scalastyle rule ready to rebase
once this gets merged in.
---
If your project is set up for it, you can reply to this email
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181233610
Seems OK to me. This is all of the occurrences then? so we could add a
scalastyle rule banning SynchronizedBuffer after this?
---
If your project is set up for it, you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181129907
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181129908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181129849
**[Test build #50905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50905/consoleFull)**
for PR 11067 at commit
[`2567ef0`](https://g
Github user tedyu commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181115720
It's nice of you to put related changes under one PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181115491
**[Test build #50905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50905/consoleFull)**
for PR 11067 at commit
[`2567ef0`](https://gi
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-181114499
@tedyu I've cherry-picked in your DirectKafkaStreamSuite changes let me
know if that looks _ok_ to you.
---
If your project is set up for it, you can reply to this ema
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-180975255
@tdas want to take a look or since its mostly tests is that not needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-180552689
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-180552692
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-180552390
**[Test build #50836 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50836/consoleFull)**
for PR 11067 at commit
[`605bb84`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-180536162
**[Test build #50836 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50836/consoleFull)**
for PR 11067 at commit
[`605bb84`](https://gi
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-180524838
@srowen simplified those two places in the test code :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11067#discussion_r52061944
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/InputStreamsSuite.scala ---
@@ -276,14 +276,12 @@ class InputStreamsSuite extends TestSuiteB
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11067#discussion_r52061559
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/StreamingListenerSuite.scala
---
@@ -271,11 +274,16 @@ class StreamingListenerSuite extends Te
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11067#discussion_r52059943
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/MasterFailureTest.scala ---
@@ -215,8 +216,8 @@ object MasterFailureTest extends Logging {
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-180297939
Minor questions; seems fine. It's actually the same simple changes in many
files and mostly touches tests
---
If your project is set up for it, you can reply to this em
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11067#discussion_r52002694
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/StreamingListenerSuite.scala
---
@@ -271,11 +274,16 @@ class StreamingListenerSuite extends Tes
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11067#discussion_r52002547
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/MasterFailureTest.scala ---
@@ -215,8 +216,8 @@ object MasterFailureTest extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11067#discussion_r52002399
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/InputStreamsSuite.scala ---
@@ -276,14 +276,12 @@ class InputStreamsSuite extends TestSuiteBase
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-179985211
also @zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/11067#issuecomment-179700506
cc @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
25 matches
Mail list logo
