Github user kevinyu98 closed the pull request at:
https://github.com/apache/spark/pull/11184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/11184#issuecomment-212496355
@marmbrus : sorry, just saw Wenchen Fan's update from jira, the problem has
been solved. I will close this PR.
---
If your project is set up for it, you can reply to
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/11184#issuecomment-212290104
@marmbrus : Hello Michael, can you help review this PR? Let me know
anything I need to change. Thank very much ! Kevin
---
If your project is set up for it, you can
Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/11184#issuecomment-194047202
I'm not sure whether the visitor pattern is a good choice here. First
introduction of a visitor just for this fix would see no less code changes;
Second Scala pattern
Github user frreiss commented on the pull request:
https://github.com/apache/spark/pull/11184#issuecomment-193530307
This change adds a new attribute `prettyDataType` to about two dozen
different classes. The new attribute is populated with code that is mostly
copied and pasted from t
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/11184#discussion_r55299643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -87,7 +87,7 @@ trait NamedExpression extends E
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/11184#discussion_r55298650
--- Diff: python/pyspark/sql/functions.py ---
@@ -250,17 +250,46 @@ def corr(col1, col2):
"""Returns a new :class:`Column` for the Pearson Correlatio
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11184#issuecomment-183452744
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
