Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-186687592
LGTM, merging into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-186660111
@davies Could you review it again?
I start working on another PR for pushing down AggregateExpression into
Aggregate. That might introduce conflicts with th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-186122845
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-186122844
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-186122497
**[Test build #51530 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51530/consoleFull)**
for PR 11198 at commit
[`63ba356`](https://g
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-186102602
LGTM pending test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-186096228
**[Test build #51530 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51530/consoleFull)**
for PR 11198 at commit
[`63ba356`](https://gi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11198#discussion_r53427826
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -927,6 +927,33 @@ class SQLQuerySuite extends QueryTest
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11198#discussion_r53425790
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -927,6 +927,33 @@ class SQLQuerySuite extends QueryTest w
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184900495
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184900493
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184900143
**[Test build #51382 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51382/consoleFull)**
for PR 11198 at commit
[`24ba670`](https://g
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11198#discussion_r53072823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -638,6 +645,17 @@ class Analyzer(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184867406
**[Test build #51382 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51382/consoleFull)**
for PR 11198 at commit
[`24ba670`](https://gi
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11198#discussion_r53072307
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -638,6 +645,17 @@ class Analyzer(
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184851646
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184851642
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184850918
**[Test build #51372 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51372/consoleFull)**
for PR 11198 at commit
[`07de4bc`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184802672
**[Test build #51372 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51372/consoleFull)**
for PR 11198 at commit
[`07de4bc`](https://gi
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184799192
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184570191
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184570186
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184569973
**[Test build #51344 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51344/consoleFull)**
for PR 11198 at commit
[`07de4bc`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184549831
**[Test build #51344 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51344/consoleFull)**
for PR 11198 at commit
[`07de4bc`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184501312
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184501309
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184501104
**[Test build #51332 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51332/consoleFull)**
for PR 11198 at commit
[`49a2d6e`](https://g
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11198#discussion_r52960865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -638,6 +645,17 @@ class Analyzer(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184471941
**[Test build #51332 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51332/consoleFull)**
for PR 11198 at commit
[`49a2d6e`](https://gi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11198#discussion_r52960702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -638,6 +645,17 @@ class Analyzer(
}
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11198#discussion_r52960600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -638,6 +645,17 @@ class Analyzer(
}
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184468332
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184466102
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184466101
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184465977
**[Test build #51325 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51325/consoleFull)**
for PR 11198 at commit
[`49a2d6e`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-184445898
**[Test build #51325 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51325/consoleFull)**
for PR 11198 at commit
[`49a2d6e`](https://gi
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-18684
@davies Besides the issue we discussed above, the latest commit also
resolves another issue. So far, if we could issue an error message like
```Can't add $missingAtt
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11198#discussion_r52944115
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -655,6 +655,8 @@ class Analyzer(
resolved
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11198#discussion_r52861656
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -655,6 +655,8 @@ class Analyzer(
resolved
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-183808318
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-183808315
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-183807835
**[Test build #51251 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51251/consoleFull)**
for PR 11198 at commit
[`c74e7b9`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11198#issuecomment-183782726
**[Test build #51251 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51251/consoleFull)**
for PR 11198 at commit
[`c74e7b9`](https://gi
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11198
[SPARK-13310] [SQL] Resolve Missing Sorting Columns in Generate
```scala
// case 1: missing sort columns are resolvable if join is true
sql("SELECT explode(a) AS val, b FROM data WHERE b
45 matches
Mail list logo
