Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-195127575
Thanks, @shivaram!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-195125133
LGTM. Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user olarayej commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r55481841
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r55474213
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-194111890
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user olarayej commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r55418947
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53749397
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user olarayej commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53701739
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-187404907
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-187404906
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-187404697
**[Test build #51676 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51676/consoleFull)**
for PR 11220 at commit
[`07e541b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-187396910
**[Test build #51676 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51676/consoleFull)**
for PR 11220 at commit
[`07e541b`](https://gi
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-187318737
Jenkins, retest please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53573498
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user olarayej commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53504008
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53417181
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user olarayej commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53375517
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user olarayej commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53373470
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53200774
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53132543
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53126613
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53126056
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/11220#discussion_r53115143
--- Diff: R/pkg/R/DataFrame.R ---
@@ -303,8 +303,28 @@ setMethod("colnames",
#' @rdname columns
#' @name colnames<-
setMethod("colnames<-",
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-184821483
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-184821476
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-184821246
**[Test build #51373 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51373/consoleFull)**
for PR 11220 at commit
[`e8c6415`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11220#issuecomment-184812178
**[Test build #51373 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51373/consoleFull)**
for PR 11220 at commit
[`e8c6415`](https://gi
GitHub user olarayej opened a pull request:
https://github.com/apache/spark/pull/11220
[SPARK-13327][SPARKR] Added parameter validations for colnames<-
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olarayej/spark SPARK-13312-3
29 matches
Mail list logo