[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-189062114 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-189062206 Actually this already passed tests, merging into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-188396725 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-188396720 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-24 Thread dragos
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-188390919 `SPARK_DEAMON_JAVA_OPTS` seems to be understood by the other daemons, so LGTM! --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-24 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-188388392 @andrewor14 Fixed your comment now, PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-24 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-188387223 @andrewor14 This is so that users can be able to set java properties when running the mesos cluster dispatcher, it's really useful for testing the dispatcher especially

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11277#discussion_r53533583 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkClassCommandBuilder.java --- @@ -48,8 +48,8 @@ String memKey = null; St

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-186449699 This looks OK, but can you elaborate on the motivation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-186443369 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-186443367 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-186442918 **[Test build #51574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51574/consoleFull)** for PR 11277 at commit [`f4460e1`](https://g

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-186408128 **[Test build #51574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51574/consoleFull)** for PR 11277 at commit [`f4460e1`](https://gi

[GitHub] spark pull request: [SPARK-13387][MESOS] Add support for SPARK_DAE...

2016-02-19 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/11277#issuecomment-186399031 @andrewor14 @dragos It's a pretty small change, PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If