Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11544
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-197229081
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r56304266
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,34 @@ class JobProgressListener(conf: SparkConf) extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-197101208
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-197101210
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-197101019
**[Test build #53242 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53242/consoleFull)**
for PR 11544 at commit
[`8314a05`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-197068266
**[Test build #53242 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53242/consoleFull)**
for PR 11544 at commit
[`8314a05`](https://gi
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r56232735
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) extends
Github user GayathriMurali commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r56221050
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf)
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r56219651
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r56219394
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196958618
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196958623
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196958157
**[Test build #53204 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53204/consoleFull)**
for PR 11544 at commit
[`9beb858`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196901679
**[Test build #53204 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53204/consoleFull)**
for PR 11544 at commit
[`9beb858`](https://gi
Github user GayathriMurali commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196896476
@andrewor14 I incorporated your suggestion to use Some instead of Option.
Can you please let me know if there is anything I can to do to get this PR
merged.
-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196704355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196704353
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196704221
**[Test build #53163 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53163/consoleFull)**
for PR 11544 at commit
[`5f452cc`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196671690
**[Test build #53163 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53163/consoleFull)**
for PR 11544 at commit
[`5f452cc`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196537330
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196537280
**[Test build #53117 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53117/consoleFull)**
for PR 11544 at commit
[`c675798`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196537328
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-196531461
**[Test build #53117 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53117/consoleFull)**
for PR 11544 at commit
[`c675798`](https://gi
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r56046157
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) exte
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55908688
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) extend
Github user GayathriMurali commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55908239
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf)
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55905361
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) exte
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195564067
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195564066
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195563762
**[Test build #52934 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52934/consoleFull)**
for PR 11544 at commit
[`228e078`](https://g
Github user GayathriMurali commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55875321
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf)
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195505678
Looks great. Just some minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55874631
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) exte
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195505249
**[Test build #52934 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52934/consoleFull)**
for PR 11544 at commit
[`228e078`](https://gi
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55874351
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) exte
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195504342
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55874268
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) exte
Github user GayathriMurali commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195210293
@jodersky Sure, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195208607
It can also be that jenkins is busy. If the test doesn't start in a couple
of hours it would probably be best to contact one of the committers, maybe Sean
Owen since h
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195207520
Jenkins has been behaving weirdly lately (at least for me). Lets try again
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195207537
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user GayathriMurali commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195206169
@jodersky Test has not started yet on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195012502
Looks good to me now. Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user GayathriMurali commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-195001394
@jodersky Please let me know if there is anything else I need to do, to
help merge this patch.
---
If your project is set up for it, you can reply to this emai
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55442441
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf) extend
Github user GayathriMurali commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55441647
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf)
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55438396
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf) extend
Github user GayathriMurali commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55430280
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf)
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55278991
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf) extend
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55278924
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,29 @@ class JobProgressListener(conf: SparkConf) extend
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-193470576
You create TaskMetrics twice (see my code comments). I'm not sure of the
actual impact, but it looks as though a duplicate is not needed.
---
If your project is set u
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11544#discussion_r55147006
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11544#issuecomment-192818252
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user GayathriMurali opened a pull request:
https://github.com/apache/spark/pull/11544
[SPARK-13396] Stop using our internal deprecated .metrics on Exceptioâ¦
JIRA: https://issues.apache.org/jira/browse/SPARK-13396
Stop using our internal deprecated .metrics on Except
55 matches
Mail list logo
