Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11371#discussion_r64522917
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1443,6 +1445,32 @@ class Analyzer(
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11371#discussion_r64521117
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1443,6 +1445,32 @@ class Analyzer(
}
/
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/11371#discussion_r64507505
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1443,6 +1445,32 @@ class Analyzer(
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11371#discussion_r64506496
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1443,6 +1445,32 @@ class Analyzer(
}
/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-219005700
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-219005701
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-219005500
**[Test build #58552 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58552/consoleFull)**
for PR 11371 at commit
[`bd13652`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-218987330
**[Test build #58552 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58552/consoleFull)**
for PR 11371 at commit
[`bd13652`](https://gi
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-218986651
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-218809716
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-218809726
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210402778
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210402776
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210402524
**[Test build #55911 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55911/consoleFull)**
for PR 11371 at commit
[`441d9a5`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210367560
**[Test build #55911 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55911/consoleFull)**
for PR 11371 at commit
[`441d9a5`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210297311
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210297313
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210297103
**[Test build #55899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55899/consoleFull)**
for PR 11371 at commit
[`1e45943`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210296251
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210296164
**[Test build #55897 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55897/consoleFull)**
for PR 11371 at commit
[`0549f88`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210296253
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210285679
**[Test build #55899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55899/consoleFull)**
for PR 11371 at commit
[`1e45943`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-210282634
**[Test build #55897 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55897/consoleFull)**
for PR 11371 at commit
[`0549f88`](https://gi
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-200239184
@cloud-fan If your pull request (#11632) merged, I think the query in the
top throws analysis exception, right? `SPARK-13484` essentially indicates that
the kinds of que
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-196710904
I think the fundamental problem is, we give users the resolved attribute
but it may not be the real column when using it. For example, `b("count")`
actually is not th
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-196707867
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-192926998
@yhuai ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-191122157
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-191122153
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-191121248
**[Test build #52300 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52300/consoleFull)**
for PR 11371 at commit
[`9c981fe`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-191084940
**[Test build #52300 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52300/consoleFull)**
for PR 11371 at commit
[`9c981fe`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-191038935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-191038926
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-191038012
**[Test build #52278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52278/consoleFull)**
for PR 11371 at commit
[`c17c2b2`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-191012390
**[Test build #52278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52278/consoleFull)**
for PR 11371 at commit
[`c17c2b2`](https://gi
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-191010575
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-190669888
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-190669891
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-190669431
**[Test build #52232 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52232/consoleFull)**
for PR 11371 at commit
[`c17c2b2`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-190639197
**[Test build #52232 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52232/consoleFull)**
for PR 11371 at commit
[`c17c2b2`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-190040111
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-190040114
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-190040034
**[Test build #52159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52159/consoleFull)**
for PR 11371 at commit
[`f1718d6`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-190026957
**[Test build #52159 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52159/consoleFull)**
for PR 11371 at commit
[`f1718d6`](https://gi
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-190025850
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189680686
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189680684
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189680630
**[Test build #52128 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52128/consoleFull)**
for PR 11371 at commit
[`f1718d6`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189662024
**[Test build #52128 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52128/consoleFull)**
for PR 11371 at commit
[`f1718d6`](https://gi
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189660570
@yhuai I added a new role 'SolveIllegalReference` to solve these kinds of
illegal references.
---
If your project is set up for it, you can reply to this email and have
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189551961
@yhuai okay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189447700
@maropu Thank you for the PR. My thought is that we may need to have a
place to correct those nullable fields in the analyzer. Let me also think about
it.
---
If your p
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189193165
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189193161
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189192642
**[Test build #52035 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52035/consoleFull)**
for PR 11371 at commit
[`d3733ba`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189191588
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189191586
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189191263
**[Test build #52034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52034/consoleFull)**
for PR 11371 at commit
[`c305776`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189153005
**[Test build #52035 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52035/consoleFull)**
for PR 11371 at commit
[`d3733ba`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189151917
**[Test build #52034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52034/consoleFull)**
for PR 11371 at commit
[`c305776`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189093305
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189093314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189092387
**[Test build #52013 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52013/consoleFull)**
for PR 11371 at commit
[`568afee`](https://g
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189085864
cc @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189073173
**[Test build #52013 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52013/consoleFull)**
for PR 11371 at commit
[`568afee`](https://gi
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-189072694
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-188905353
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-188905351
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-188905098
**[Test build #51976 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51976/consoleFull)**
for PR 11371 at commit
[`568afee`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-188902690
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-188902691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-188902402
**[Test build #51972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51972/consoleFull)**
for PR 11371 at commit
[`9f8ff3d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-188861591
**[Test build #51976 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51976/consoleFull)**
for PR 11371 at commit
[`568afee`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11371#issuecomment-188861433
**[Test build #51972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51972/consoleFull)**
for PR 11371 at commit
[`9f8ff3d`](https://gi
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/11371
[SPARK-13484][SQL] Prevent illegal NULL propagation when filtering
outer-join results
## What changes were proposed in this pull request?
This pr is to prevent illegal NULL propagation in the qu
75 matches
Mail list logo