Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-197538227
> Do you think should I make a Jira issue for this?
Please do; this means that APIs that are being changed from public to
private might not trigger MiMA
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-197541126
Oh, that's great, @JoshRosen .
I made a Jira issue, but could you change that appropriately with yours?
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-197538496
Oh, thank you for fast response. I'll do right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-197617528
I don't think that MiMa is necessarily capable of detecting this problem
for things which are evolved to become `private[spark]` because Scala
package-private
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-197537154
Oh, @vanzin .
Sorry for writing comments at the closed PR.
I've read your concern and investigate some. The root cause was
`GenerateMIMAIgnore.scala`
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-197539765
I think this problem relates to the fact that the SparkConf companion
object is `private[spark]` and our exclusion generator inappropriately handles
cases where
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-197040263
unrelated test failure. merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-196967430
**[Test build #53205 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53205/consoleFull)**
for PR 11734 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-196967642
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-196967644
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-196932442
LGtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-196922954
BTW it's a little worrying that MiMA didn't catch this in the original
change.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-196919823
**[Test build #53205 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53205/consoleFull)**
for PR 11734 at commit
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/11734
[SPARK-13626] [core] Revert change to SparkConf's constructor.
It shouldn't be private.
You can merge this pull request into a Git repository by running:
$ git pull
15 matches
Mail list logo
