Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-200152103
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-200152102
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-200151982
**[Test build #53867 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53867/consoleFull)**
for PR 11498 at commit
[`0fee604`](https://g
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11498#discussion_r57098043
--- Diff:
core/src/main/scala/org/apache/spark/storage/disk/DiskBlockObjectWriter.scala
---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Softw
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11498#discussion_r57097978
--- Diff:
core/src/main/scala/org/apache/spark/storage/disk/DiskBlockObjectWriter.scala
---
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Softw
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-200112739
**[Test build #53867 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53867/consoleFull)**
for PR 11498 at commit
[`0fee604`](https://gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11498#discussion_r57097023
--- Diff:
core/src/main/scala/org/apache/spark/storage/disk/DiskBlockObjectWriter.scala
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Softw
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-199963977
This LGTM overall, once you address these comments, I think it's good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11498#discussion_r57048124
--- Diff:
core/src/main/scala/org/apache/spark/storage/disk/DiskBlockObjectWriter.scala
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11498#discussion_r57047616
--- Diff:
core/src/main/scala/org/apache/spark/storage/disk/DiskBlockObjectWriter.scala
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11498#discussion_r57047243
--- Diff:
core/src/main/scala/org/apache/spark/storage/disk/DiskBlockObjectWriter.scala
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11498#discussion_r57045537
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java
---
@@ -23,6 +23,7 @@
import java.io.IOException;
impo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195600654
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195600655
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195600102
**[Test build #52947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52947/consoleFull)**
for PR 11498 at commit
[`9fdde9f`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195593967
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195593973
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195593458
**[Test build #52945 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52945/consoleFull)**
for PR 11498 at commit
[`c04d3d7`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195591761
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195591764
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195591564
**[Test build #52944 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52944/consoleFull)**
for PR 11498 at commit
[`8b8f4cb`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195549353
**[Test build #52947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52947/consoleFull)**
for PR 11498 at commit
[`9fdde9f`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195544738
**[Test build #52945 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52945/consoleFull)**
for PR 11498 at commit
[`c04d3d7`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-195543538
**[Test build #52944 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52944/consoleFull)**
for PR 11498 at commit
[`8b8f4cb`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-191971867
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-191971864
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-191971576
**[Test build #52405 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52405/consoleFull)**
for PR 11498 at commit
[`a33893d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11498#issuecomment-191925670
**[Test build #52405 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52405/consoleFull)**
for PR 11498 at commit
[`a33893d`](https://gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11498#discussion_r54933191
--- Diff:
core/src/main/scala/org/apache/spark/storage/disk/DiskBlockObjectWriter.scala
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Softw
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/11498
[SPARK-13653] Split disk writer into separate object and binary writers
This patch splits `DiskBlockObjectWriter` into two separate classes so that
the object-based and byte-based write methods a
30 matches
Mail list logo
