Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11517
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204564823
Chatted with @mengxr , it's OK to remove the class tag.
LGTM, merging this into master, thanks!
---
If your project is set up for it, you can reply to this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204349166
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204349165
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204348987
**[Test build #54696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54696/consoleFull)**
for PR 11517 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204327574
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204327572
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204327322
**[Test build #54690 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54690/consoleFull)**
for PR 11517 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204316401
**[Test build #54696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54696/consoleFull)**
for PR 11517 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204312598
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204311910
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204311911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204311884
**[Test build #54693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54693/consoleFull)**
for PR 11517 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204309253
**[Test build #54693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54693/consoleFull)**
for PR 11517 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58175716
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
---
@@ -85,6 +85,66 @@ class BenchmarkWholeStageCodegen
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58174661
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
---
@@ -85,6 +85,66 @@ class BenchmarkWholeStageCodegen
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58174636
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
---
@@ -85,6 +85,66 @@ class BenchmarkWholeStageCodegen
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58170829
--- Diff:
core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
@@ -186,7 +186,7 @@ class BernoulliSampler[T: ClassTag](fraction: Double)
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58170654
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
---
@@ -85,6 +85,66 @@ class BenchmarkWholeStageCodegen
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58170614
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
---
@@ -85,6 +85,66 @@ class BenchmarkWholeStageCodegen
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204284201
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204284197
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204283360
**[Test build #54686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54686/consoleFull)**
for PR 11517 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204279636
**[Test build #54690 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54690/consoleFull)**
for PR 11517 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204251175
**[Test build #54686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54686/consoleFull)**
for PR 11517 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58161386
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58160147
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58159707
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58159480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58159371
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58158879
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58157898
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58157878
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58157092
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58091069
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204003153
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204002776
**[Test build #54629 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54629/consoleFull)**
for PR 11517 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-204003149
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203956351
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203956820
**[Test build #54629 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54629/consoleFull)**
for PR 11517 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203956320
Not sure why the test failed..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203889637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203889632
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203889564
**[Test build #54620 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54620/consoleFull)**
for PR 11517 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203885033
**[Test build #54620 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54620/consoleFull)**
for PR 11517 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203884424
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203877176
**[Test build #54618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54618/consoleFull)**
for PR 11517 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203877207
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203877205
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203874596
**[Test build #54618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54618/consoleFull)**
for PR 11517 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203868096
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203868097
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203868077
**[Test build #54614 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54614/consoleFull)**
for PR 11517 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58030135
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203864696
**[Test build #54614 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54614/consoleFull)**
for PR 11517 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58009018
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/BufferedRowIterator.java
---
@@ -61,6 +63,14 @@ public long durationMs() {
public
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58008863
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -194,6 +194,71 @@ case class Sample(
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-203790582
@viirya Could you also add `numOutputRow` for Sample ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58008649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -194,6 +194,71 @@ case class Sample(
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58008150
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -194,6 +194,71 @@ case class Sample(
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58007758
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -194,6 +194,71 @@ case class Sample(
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r58007651
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -275,8 +340,8 @@ case class Range(
| // initialize
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-202727113
@davies This is rebased. Please take a look. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-202715746
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-202715747
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-202715594
**[Test build #54409 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54409/consoleFull)**
for PR 11517 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-202695911
**[Test build #54409 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54409/consoleFull)**
for PR 11517 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r56832501
--- Diff:
core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
@@ -107,6 +113,28 @@ class BernoulliCellSampler[T](lb: Double, ub: Double,
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r56830819
--- Diff:
core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
@@ -107,6 +113,28 @@ class BernoulliCellSampler[T](lb: Double, ub: Double,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-199195050
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-199195048
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-199194643
**[Test build #53665 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53665/consoleFull)**
for PR 11517 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-199158078
**[Test build #53665 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53665/consoleFull)**
for PR 11517 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r55492271
--- Diff:
core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
@@ -41,6 +41,12 @@ trait RandomSampler[T, U] extends Pseudorandom with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-194170678
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-194170676
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-194170327
**[Test build #52726 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52726/consoleFull)**
for PR 11517 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-194128908
**[Test build #52726 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52726/consoleFull)**
for PR 11517 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-194128858
cc @davies @nongli
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r55475400
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PartitionwiseSampledRDDSuite.scala ---
@@ -29,6 +29,8 @@ class MockSampler extends RandomSampler[Long,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r55475367
--- Diff:
core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
@@ -41,6 +41,12 @@ trait RandomSampler[T, U] extends Pseudorandom with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-193217451
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-193217449
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-193217119
**[Test build #52546 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52546/consoleFull)**
for PR 11517 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-193172297
**[Test build #52546 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52546/consoleFull)**
for PR 11517 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-192242994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-192242990
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-192242790
**[Test build #52460 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52460/consoleFull)**
for PR 11517 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11517#discussion_r55010439
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala
---
@@ -84,6 +84,31 @@ class BenchmarkWholeStageCodegen
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11517#issuecomment-192213460
**[Test build #52460 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52460/consoleFull)**
for PR 11517 at commit
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/11517
[SPARK-13674][SQL] Add wholestage codegen support to Sample
JIRA: https://issues.apache.org/jira/browse/SPARK-13674
## What changes were proposed in this pull request?
Sample
91 matches
Mail list logo
