[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-20 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/11790 [SPARK-13761] [ML] Remove remaining uses of validateParams ## What changes were proposed in this pull request? Cleanups from [https://github.com/apache/spark/pull/11620]: remove remainin

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-19 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/11790#discussion_r56558786 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala --- @@ -31,6 +32,7 @@ private[ml] trait ValidatorParams extends Params {

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11790#issuecomment-198035808 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11790#issuecomment-198015781 **[Test build #53447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53447/consoleFull)** for PR 11790 at commit [`3f02142`](https://gi

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-19 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/11790#issuecomment-198032457 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11790#issuecomment-198066796 @hhbyyh Thanks for reviewing it! I'll merge it with master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11790#issuecomment-198035617 **[Test build #53447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53447/consoleFull)** for PR 11790 at commit [`3f02142`](https://g

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11790 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/11790#discussion_r56571141 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/ValidatorParams.scala --- @@ -31,6 +32,7 @@ private[ml] trait ValidatorParams extends Params {

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11790#issuecomment-198014977 CC: @hhbyyh Could you please take a look at this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-13761] [ML] Remove remaining uses of va...

2016-03-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11790#issuecomment-198035803 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec