Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197870246
LGTM, and the original reporter confirmed it works. I'm merging to master.
I'm open to an argument that this should go into 1.6 though the scope of the
problem is quite
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197975823
Agree that this doesn't need to go into 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11615
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197123001
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197122996
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197122296
**[Test build #53249 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53249/consoleFull)**
for PR 11615 at commit
[`068887b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197084544
**[Test build #53249 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53249/consoleFull)**
for PR 11615 at commit
[`068887b`](https://gi
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197082842
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197072970
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197072971
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197072847
**[Test build #53232 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53232/consoleFull)**
for PR 11615 at commit
[`068887b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197048186
**[Test build #53232 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53232/consoleFull)**
for PR 11615 at commit
[`068887b`](https://gi
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197047893
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197042406
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197042409
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197042177
**[Test build #53221 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53221/consoleFull)**
for PR 11615 at commit
[`068887b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-197005370
**[Test build #53221 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53221/consoleFull)**
for PR 11615 at commit
[`068887b`](https://gi
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r56233519
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -134,7 +134,7 @@ private[spark] abstract class WebUI(
def bind() {
assert
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r56232500
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -134,7 +134,7 @@ private[spark] abstract class WebUI(
def bind() {
assert(
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-196987607
@srowen what do you think now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195604242
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195604240
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195604040
**[Test build #52949 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52949/consoleFull)**
for PR 11615 at commit
[`e772aed`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195560080
**[Test build #52949 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52949/consoleFull)**
for PR 11615 at commit
[`e772aed`](https://gi
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55888314
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55888190
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55883199
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195521449
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195521428
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11615#issuecomment-195521097
**[Test build #52931 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52931/consoleFull)**
for PR 11615 at commit
[`8422f6e`](https://g
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55872166
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55871640
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55869059
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55868740
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {
34 matches
Mail list logo