Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195580608
**[Test build #52954 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52954/consoleFull)**
for PR 11649 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195579496
In this commit, three parts are done:
- removed the `IsNotNull` constraints for compound expressions
- added `IsNotNull` constraints support for all the
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195564292
@marmbrus
Are you saying we should not add null filters for `Filter`?
https://github.com/apache/spark/pull/11372 The original PR shows it can benefit
some
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195544498
I guess my question is why we are doing this for filters at all. It makes
sense for joins, but perhaps we should just eliminate that part of the rule.
---
If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195463505
@sameeragarwal True, we can add it back when needing it. Let me directly
filter it out in `constructIsNotNullConstraints`
---
If your project is set up for it, you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195257436
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195257438
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195256795
**[Test build #52907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52907/consoleFull)**
for PR 11649 at commit
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195238973
@gatorsmile this change makes sense to me, however what are your thoughts
on slightly widening the scope of this change and not generating `IsNotNull`
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11649#issuecomment-195224673
**[Test build #52907 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52907/consoleFull)**
for PR 11649 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11649
[SPARK-13811] [SQL] No Push-Down of Constraints-generated Null Filtering of
Compound Expressions
What changes were proposed in this pull request?
We generate `IsNotNull`
11 matches
Mail list logo
