Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r61081773
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -218,11 +292,135 @@ class ALSModel private[ml] (
predict(userF
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r61081233
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -374,9 +599,26 @@ class ALS(@Since("1.4.0") override val uid: String)
exte
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r61081248
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -200,8 +240,42 @@ class ALSModel private[ml] (
@Since("1.3.0")
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60960027
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -374,9 +599,26 @@ class ALS(@Since("1.4.0") override val uid: String)
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60959688
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -200,8 +240,42 @@ class ALSModel private[ml] (
@Since("1.3.0")
Github user frreiss commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214463888
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60958628
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
---
@@ -261,58 +261,93 @@ object MatrixFactorizationMode
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60958325
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -218,11 +292,135 @@ class ALSModel private[ml] (
predict(user
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214304572
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214304580
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214304366
**[Test build #56895 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56895/consoleFull)**
for PR 12574 at commit
[`4af7105`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214300936
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214300939
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214300797
**[Test build #56894 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56894/consoleFull)**
for PR 12574 at commit
[`c529c89`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214292396
**[Test build #56895 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56895/consoleFull)**
for PR 12574 at commit
[`4af7105`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214287719
**[Test build #56894 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56894/consoleFull)**
for PR 12574 at commit
[`c529c89`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214004079
**[Test build #56849 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56849/consoleFull)**
for PR 12574 at commit
[`f8cf8b4`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214004091
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214004090
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214001419
**[Test build #56849 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56849/consoleFull)**
for PR 12574 at commit
[`f8cf8b4`](https://gi
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-214001249
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60825440
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -218,11 +292,135 @@ class ALSModel private[ml] (
predict(userF
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60825409
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
---
@@ -261,58 +261,93 @@ object MatrixFactorizationModel
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60825392
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
---
@@ -261,58 +261,93 @@ object MatrixFactorizationModel
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60779700
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
---
@@ -261,58 +261,93 @@ object MatrixFactorizationMode
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60777217
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
---
@@ -261,58 +261,93 @@ object MatrixFactorizationMode
Github user frreiss commented on a diff in the pull request:
https://github.com/apache/spark/pull/12574#discussion_r60775792
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -218,11 +292,135 @@ class ALSModel private[ml] (
predict(user
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-213287357
Test failure seems to be caused by issue in #12599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-212955658
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-212955649
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-21291
**[Test build #56544 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56544/consoleFull)**
for PR 12574 at commit
[`f8cf8b4`](https://g
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-212939059
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-212940321
**[Test build #56544 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56544/consoleFull)**
for PR 12574 at commit
[`f8cf8b4`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-212897823
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-212897791
**[Test build #56533 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56533/consoleFull)**
for PR 12574 at commit
[`f8cf8b4`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-212897826
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-212886112
Adding some further detail...
## Proposed semantics
* `ALSModel.transform` handles both point predictions (predict `rating` for
each `(user, item)` combo in
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12574#issuecomment-212885451
**[Test build #56533 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56533/consoleFull)**
for PR 12574 at commit
[`f8cf8b4`](https://gi
GitHub user MLnick opened a pull request:
https://github.com/apache/spark/pull/12574
[SPARK-13857][ML][WIP] Add "recommend all" functionality in ALS
This PR adds "recommend all" functionality to ML's `ALSModel`, similar to
what exists in the `recommendProductsForUsers/recommendUsers
39 matches
Mail list logo
