Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197590831
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197561885
Removing Shark docs part looks OK. The slightly controversial bit is making
`SparkEnv` private. People might depend on that. @rxin
---
If your project is set up for
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197592697
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197589588
Now I cleaned up the description of this PR and JIRA consistently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197589743
**[Test build #53370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53370/consoleFull)**
for PR 11770 at commit
[`74e51b1`](https://gi
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/11770
[SPARK-13942][CORE][DOCS] Remove Shark-related docs and visibility for 2.x
## What changes were proposed in this pull request?
`Shark` was merged into `Spark SQL` since [July
2014](h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197593028
**[Test build #53370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53370/consoleFull)**
for PR 11770 at commit
[`74e51b1`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197571760
**[Test build #53361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53361/consoleFull)**
for PR 11770 at commit
[`e6707f1`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197620311
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197521540
**[Test build #53342 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53342/consoleFull)**
for PR 11770 at commit
[`f91c548`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197592492
**[Test build #53342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53342/consoleFull)**
for PR 11770 at commit
[`f91c548`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197620150
**[Test build #53361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53361/consoleFull)**
for PR 11770 at commit
[`e6707f1`](https://g
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11770#discussion_r56421136
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -46,12 +46,9 @@ import org.apache.spark.util.{RpcUtils, Utils}
* including the s
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197620315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197593212
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197568243
Sure! No problem.
Thank you for discuss about this.
Thank you, @andrewor14 and @rxin .
---
If your project is set up for it, you can reply to this email
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197591298
Thank you, @rxin !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197566260
Probably OK to make it private since everything else is - let's see if
people complain. But we should discuss it at the dev list.
For now, can you just remove the
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11770
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11770#discussion_r56427806
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -46,9 +46,6 @@ import org.apache.spark.util.{RpcUtils, Utils}
* including the serializ
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/11770#discussion_r56428060
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -46,9 +46,6 @@ import org.apache.spark.util.{RpcUtils, Utils}
* including the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197592700
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197572471
BTW, if you're going to consider changing `SparkEnv` then I'd remove the
deprecated methods from back when it used to be a thread-local.
---
If your project is set u
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197591689
I'm merging this in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11770#issuecomment-197593208
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
25 matches
Mail list logo
