Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-203126771
Thanks for merging--just saw notification!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-202825496
merged to master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-202823481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-202823446
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-202823191
**[Test build #54428 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54428/consoleFull)**
for PR 11832 at commit
[`d6431eb`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-202807894
**[Test build #54428 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54428/consoleFull)**
for PR 11832 at commit
[`d6431eb`](https://gi
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-202807584
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-200922079
LGTM - I'm traveling and don't have decent web access, so @jkbradley could
you merge?
On Thu, 24 Mar 2016 at 18:36, Bryan Cutler wrote:
> I think it is g
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-200915659
I think it is good to go unless @MLnick has any more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-200659606
LGTM Ready to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r57273260
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/HashingTF.scala ---
@@ -53,9 +65,10 @@ class HashingTF(val numFeatures: Int) extends
Seriali
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-199976351
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-199976346
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-199975647
**[Test build #53798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53798/consoleFull)**
for PR 11832 at commit
[`d6431eb`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-199953336
**[Test build #53798 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53798/consoleFull)**
for PR 11832 at commit
[`d6431eb`](https://gi
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r57041720
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala ---
@@ -52,6 +52,27 @@ class HashingTFSuite extends SparkFunSuite with
M
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r57032672
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala ---
@@ -52,6 +52,27 @@ class HashingTFSuite extends SparkFunSuite with
MLlibT
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r57030239
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala ---
@@ -52,6 +52,27 @@ class HashingTFSuite extends SparkFunSuite with
M
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r56948484
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala ---
@@ -52,6 +52,27 @@ class HashingTFSuite extends SparkFunSuite with
MLlibT
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r56948444
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala ---
@@ -52,6 +52,27 @@ class HashingTFSuite extends SparkFunSuite with
MLlibT
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r56948423
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala ---
@@ -52,6 +52,27 @@ class HashingTFSuite extends SparkFunSuite with
MLlibT
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r56947750
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/HashingTF.scala ---
@@ -53,9 +65,10 @@ class HashingTF(val numFeatures: Int) extends
Serializab
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r56897863
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala ---
@@ -52,6 +52,27 @@ class HashingTFSuite extends SparkFunSuite with
M
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r56896101
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/HashingTF.scala ---
@@ -53,9 +65,10 @@ class HashingTF(val numFeatures: Int) extends
Seria
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r56787382
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/HashingTFSuite.scala ---
@@ -52,6 +52,27 @@ class HashingTFSuite extends SparkFunSuite with
MLlibT
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r56787196
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/HashingTF.scala ---
@@ -53,9 +65,10 @@ class HashingTF(val numFeatures: Int) extends
Serializab
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-198560033
**[Test build #53570 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53570/consoleFull)**
for PR 11832 at commit
[`ca14361`](https://g
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-198924173
LGTM apart from the small doc comment. Will leave open for a while for any
other comments (cc @jkbradley)
---
If your project is set up for it, you can reply to this em
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11832#discussion_r56763755
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/HashingTF.scala ---
@@ -36,12 +36,24 @@ import org.apache.spark.util.Utils
@Since("1.1.0")
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-198560044
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-198594462
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/11832
[SPARK-13963][ML] Adding binary toggle param to HashingTF
## What changes were proposed in this pull request?
Adding binary toggle parameter to ml.feature.HashingTF, as well as
mllib.featur
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-198560043
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-198556902
**[Test build #53570 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53570/consoleFull)**
for PR 11832 at commit
[`ca14361`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-198594461
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-198594419
**[Test build #53588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53588/consoleFull)**
for PR 11832 at commit
[`19849fe`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11832#issuecomment-198587059
**[Test build #53588 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53588/consoleFull)**
for PR 11832 at commit
[`19849fe`](https://gi
38 matches
Mail list logo
