Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11792
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202691066
Thanks - merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202660290
**[Test build #2706 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2706/consoleFull)**
for PR 11792 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202624401
**[Test build #2706 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2706/consoleFull)**
for PR 11792 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202593045
**[Test build #2702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2702/consoleFull)**
for PR 11792 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202567799
**[Test build #2702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2702/consoleFull)**
for PR 11792 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202566479
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202566481
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202566071
**[Test build #54342 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54342/consoleFull)**
for PR 11792 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202531604
**[Test build #54342 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54342/consoleFull)**
for PR 11792 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11792#discussion_r57605732
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -110,39 +114,81 @@ case class Filter(condition: Expression,
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-202509546
LGTM, just two minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11792#discussion_r57605200
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -110,39 +114,81 @@ case class Filter(condition: Expression,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-201601826
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-201601820
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-201601013
**[Test build #54228 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54228/consoleFull)**
for PR 11792 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-201551994
**[Test build #54228 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54228/consoleFull)**
for PR 11792 at commit
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-201059224
@davies I did this a different way. Let me know your thoughts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-201058982
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-201058978
**[Test build #54107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54107/consoleFull)**
for PR 11792 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-201058988
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-201058647
**[Test build #54107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54107/consoleFull)**
for PR 11792 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11792#discussion_r57065601
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -110,23 +114,28 @@ case class Filter(condition: Expression,
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11792#discussion_r57064001
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -110,23 +114,28 @@ case class Filter(condition: Expression,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11792#discussion_r56916217
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -110,23 +114,28 @@ case class Filter(condition: Expression,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-199537228
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-199537232
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-199536766
**[Test build #53715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53715/consoleFull)**
for PR 11792 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-199506893
**[Test build #53715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53715/consoleFull)**
for PR 11792 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-198059282
**[Test build #53463 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53463/consoleFull)**
for PR 11792 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-198090295
**[Test build #53463 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53463/consoleFull)**
for PR 11792 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-198090942
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11792#discussion_r56592392
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -110,23 +114,34 @@ case class Filter(condition: Expression,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11792#discussion_r56590134
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -110,23 +114,34 @@ case class Filter(condition: Expression,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11792#discussion_r56590282
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -110,23 +114,34 @@ case class Filter(condition: Expression,
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-198060051
Generated code before:
```
InternalRow scan_row = scan_batch.getRow(scan_batchIdx++);
/* input[0, int] */
boolean scan_isNull =
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11792#discussion_r56590311
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -110,23 +114,34 @@ case class Filter(condition: Expression,
GitHub user nongli opened a pull request:
https://github.com/apache/spark/pull/11792
[SPARK-13981][SQL] Defer evaluating variables within Filter operator.
## What changes were proposed in this pull request?
This improves the Filter codegen to defer loading variables within
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11792#issuecomment-198090947
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
39 matches
Mail list logo
