Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11799#discussion_r56700441
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTest.scala
---
@@ -51,8 +51,10 @@ private[sql] trait ParquetTest
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11799#discussion_r56701451
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTest.scala
---
@@ -51,8 +51,10 @@ private[sql] trait ParquetTest
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198152113
Thanks, all comments addressed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-19839
**[Test build #53476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53476/consoleFull)**
for PR 11799 at commit
[`9fdb852`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198537363
**[Test build #53554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53554/consoleFull)**
for PR 11799 at commit
[`b18ad0c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198506875
**[Test build #53554 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53554/consoleFull)**
for PR 11799 at commit
[`b18ad0c`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198176963
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198142035
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198529953
LGTM, will merge it once it passed tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198538107
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198141927
**[Test build #53477 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53477/consoleFull)**
for PR 11799 at commit
[`ef90585`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198142033
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198136602
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198152267
**[Test build #53490 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53490/consoleFull)**
for PR 11799 at commit
[`01357e5`](https://gi
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198137446
Patch looks good. Can you look for places where we enable unsafe row and
disable vectorized (maybe just grep files that have both flags) and remove what
is not relevant?
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198136453
**[Test build #53476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53476/consoleFull)**
for PR 11799 at commit
[`9fdb852`](https://g
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11799#discussion_r56708866
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTest.scala
---
@@ -51,8 +51,10 @@ private[sql] trait Parqu
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11799#discussion_r56700958
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTest.scala
---
@@ -51,8 +51,10 @@ private[sql] trait Parqu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198538111
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198116450
**[Test build #53477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53477/consoleFull)**
for PR 11799 at commit
[`ef90585`](https://gi
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198111826
Can you undo the file rename? It makes this hard to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198115099
oops sorry, that was because I moved `ColumnReader` to a new file. Reverted
that change!
---
If your project is set up for it, you can reply to this email and ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198176967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198541953
Merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198111228
cc @nongli
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198136599
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11799#issuecomment-198176796
**[Test build #53490 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53490/consoleFull)**
for PR 11799 at commit
[`01357e5`](https://g
GitHub user sameeragarwal opened a pull request:
https://github.com/apache/spark/pull/11799
[SPARK-13989][SQL] Remove non-vectorized/unsafe-row parquet record reader
## What changes were proposed in this pull request?
This PR cleans up the new parquet record reader with the
29 matches
Mail list logo
