Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-200573435
Thank you all for your kind review & comments, @srowen @andrewor14 @zsxwing
!
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-200565179
LGTM. Merging to master. Thanks, @lw-lin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11845
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-200168135
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-200168137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-200167891
**[Test build #53869 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53869/consoleFull)**
for PR 11845 at commit
[`0761e5f`](https://g
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11845#discussion_r57100194
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -417,7 +417,7 @@ private[spark] object UIUtils extends Logging {
* attempts to e
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11845#discussion_r57100182
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -445,22 +445,36 @@ private[spark] object UIUtils extends Logging {
"Links
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-200127975
**[Test build #53869 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53869/consoleFull)**
for PR 11845 at commit
[`0761e5f`](https://gi
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-200066336
Looks pretty good. @zsxwing can you have a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11845#discussion_r57082964
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -445,22 +445,36 @@ private[spark] object UIUtils extends Logging {
"L
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11845#discussion_r57082998
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -417,7 +417,7 @@ private[spark] object UIUtils extends Logging {
* attempts
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199867357
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199867366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199866576
**[Test build #53770 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53770/consoleFull)**
for PR 11845 at commit
[`ebe1182`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199811621
**[Test build #53770 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53770/consoleFull)**
for PR 11845 at commit
[`ebe1182`](https://gi
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199750468
It failed on a line you modified so it is due to this change. The error
message explains what you need to change.
---
If your project is set up for it, you can reply to
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199727209
Updated with new commits.
Tests passed on my local machine; I wonder why scalastyle checks failed
(this PR doesn't touch this code snippet):
>
Scala
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199680181
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199680178
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199680174
**[Test build #53755 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53755/consoleFull)**
for PR 11845 at commit
[`22ac2d9`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199679910
**[Test build #53755 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53755/consoleFull)**
for PR 11845 at commit
[`22ac2d9`](https://gi
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199583350
@andrewor14 thank you for the informative review. Will soon update this PR
accordingly.
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199402501
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199402824
@lw-lin thanks for summarizing the issue. Yes, we don't want to process
arbitrary HTML so we don't have to worry about potential XSS threats. However,
I agree with @
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199402507
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199402457
**[Test build #53688 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53688/consoleFull)**
for PR 11845 at commit
[`0f32845`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199396690
**[Test build #53688 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53688/consoleFull)**
for PR 11845 at commit
[`0f32845`](https://gi
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-199396154
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198718851
Maybe @andrewor14 will explain better :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198718502
Ah, I guess the reason is:
- for the blue box in the event timeline, itself is clickable both for
streaming/non-streaming jobs, so it's unnecessary to contain any HTM
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198715624
My question is, why escape it? the library will accept and render HTML and
that is desirable here right?
---
If your project is set up for it, you can reply to this ema
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198714597
Maybe let's summarize a little bit:
- job/stage descriptions are used at 2 places: the `Event Timeline` and the
text tables (`CompletedJobs`/`CompletedStages`)
-
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198710234
Actually we've intentionally escaped the description for the event line, so
that it will be rendered as plain texts; please see
https://github.com/apache/spark/blob/mast
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198708658
Besides, the blue/green bar in the event line itself is a clickable,
linking to the specific job page. The `` thing is superfluous, let's
figure out how to remove it.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198709371
Ah I thought this was a tooltip, where HTML can't render, but it's not. I
wonder, is the problem just that this is rendered as text and not HTML? if it's
controlled by t
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198707142
@srowen thanks for looking at this!
I believe job descriptions were intended to contains only plain texts at
first, but HTMLs were introduced in for streaming jo
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198702731
I agree it's a problem, but this seems like a hacky way to band-aid it,
with a second version of the description and a flag passed around. Is the
problem not just that t
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198695846
@andrewor14 @zsxwing would you mind taking a look at this when you have
time? Thanks!
---
If your project is set up for it, you can reply to this email and have your
re
GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/11845
[SPARK-14025][STREAMING][WEBUI] Fix streaming job descriptions on the event
line
## What changes were proposed in this pull request?
Removed the extra `...` for each streaming job's
descri
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11845#issuecomment-198695774
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
41 matches
Mail list logo
