Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11891
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-204551972
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-204259326
ping @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201966523
@liancheng : I have made all requested changes as per review and also
rebased. Can you please take a look ?
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201959124
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201959127
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201958767
**[Test build #54267 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54267/consoleFull)**
for PR 11891 at commit
[`3c25e7e`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201945963
**[Test build #54267 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54267/consoleFull)**
for PR 11891 at commit
[`3c25e7e`](https://gi
Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201945359
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201069916
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201069915
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201069717
**[Test build #54097 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54097/consoleFull)**
for PR 11891 at commit
[`4f0fe06`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201064599
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201064602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201064349
**[Test build #54092 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54092/consoleFull)**
for PR 11891 at commit
[`4b459a0`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201041505
**[Test build #54097 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54097/consoleFull)**
for PR 11891 at commit
[`4f0fe06`](https://gi
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57393457
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -400,4 +400,33 @@ class OrcQuerySuite extends QueryTest with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201029900
**[Test build #54092 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54092/consoleFull)**
for PR 11891 at commit
[`4b459a0`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201012587
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201012585
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-201012068
**[Test build #54071 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54071/consoleFull)**
for PR 11891 at commit
[`0a03a78`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200982183
**[Test build #54071 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54071/consoleFull)**
for PR 11891 at commit
[`0a03a78`](https://gi
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200696198
Ah, unfortunately we just reverted #11836 because it caused some
regressions. This caused another compilation error for your PR... Sorry for the
trouble...
---
If y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200694397
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200694386
**[Test build #54010 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54010/consoleFull)**
for PR 11891 at commit
[`c4111fa`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200694394
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200693807
**[Test build #54010 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54010/consoleFull)**
for PR 11891 at commit
[`c4111fa`](https://gi
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200693267
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200693244
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57278305
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -400,4 +400,33 @@ class OrcQuerySuite extends QueryTest with
Be
Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200627141
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200607485
@liancheng : I rebased and fixed the problem. Also, thanks for the pointer
for debugging the tests.
---
If your project is set up for it, you can reply to this ema
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200600419
@tejasapatil Just saw your previous comment about debugging in IntelliJ.
When I have to resort to the debugger, I usually run tests using SBT and debug
with IntelliJ
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200596299
@tejasapatil When testing a PR, Jenkins always tries to merge it with the
most recent master (or any other branch against which the PR is opened) first.
I think the r
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200579890
**[Test build #53983 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53983/consoleFull)**
for PR 11891 at commit
[`c4111fa`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200579894
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200579896
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200578146
**[Test build #53983 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53983/consoleFull)**
for PR 11891 at commit
[`c4111fa`](https://gi
Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200562818
@liancheng + @marmbrus : Thanks for your comments. I have made the
suggested changes except the one related to test case which I am not sure how
to do.
Als
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200554894
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200554883
**[Test build #53969 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53969/consoleFull)**
for PR 11891 at commit
[`c15a39f`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200554890
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200553452
**[Test build #53969 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53969/consoleFull)**
for PR 11891 at commit
[`c15a39f`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200551398
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200551393
**[Test build #53968 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53968/consoleFull)**
for PR 11891 at commit
[`c71bb6c`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200551400
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57240228
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -597,6 +619,107 @@ private[hive] class HiveMetastoreCatalog
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57240256
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -597,6 +619,107 @@ private[hive] class HiveMetastoreCatalog
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200550997
**[Test build #53968 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53968/consoleFull)**
for PR 11891 at commit
[`c71bb6c`](https://gi
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57240207
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -439,6 +440,56 @@ private[hive] class HiveMetastoreCatalog(
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57240111
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -400,4 +400,33 @@ class OrcQuerySuite extends QueryTest with
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57240048
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -597,6 +619,107 @@ private[hive] class HiveMetastoreCatalog
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57239903
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -400,4 +400,33 @@ class OrcQuerySuite extends QueryTest with
Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57239593
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -439,6 +440,56 @@ private[hive] class HiveMetastoreCatalog(
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57192898
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -597,6 +619,107 @@ private[hive] class HiveMetastoreCatalog(v
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57192019
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -597,6 +619,107 @@ private[hive] class HiveMetastoreCatalog(v
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57191905
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -597,6 +619,107 @@ private[hive] class HiveMetastoreCatalog(v
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57183266
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -439,6 +440,56 @@ private[hive] class HiveMetastoreCatalog(va
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57183239
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -400,4 +400,33 @@ class OrcQuerySuite extends QueryTest with
Be
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57183106
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -400,4 +400,33 @@ class OrcQuerySuite extends QueryTest with
Be
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57091067
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -597,6 +619,107 @@ private[hive] class HiveMetastoreCatalog(va
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200081805
I've never gotten testing running to work in intelij unfortunately. You
can use SBT as follows:
```
spark/$ sbt/sbt -Phive
> hive/test-only *HiveCompa
Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200078443
@rxin : Can you point me to specific features / changes in Parquet which
are not in ORC ? I am happy to work on adding that to ORC.
---
If your project is set up f
Github user tejasapatil commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200077504
@marmbrus : I looked at the build failures trying to figure out the cause :
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53806/
I nee
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-200022810
This is pretty cool -- the hive path is ridiculously slow. BTW I tried
comparing Parquet vs ORC based on Spark master branch right now.
I generated 100 million ro
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-24857
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-24862
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-24597
**[Test build #53806 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53806/consoleFull)**
for PR 11891 at commit
[`0938c08`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-199964746
**[Test build #53806 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53806/consoleFull)**
for PR 11891 at commit
[`0938c08`](https://gi
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-199963392
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11891#issuecomment-199908257
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
71 matches
Mail list logo
