[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11936 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201948284 Thanks. I am merging this to master. @liancheng @cloud-fan Let's address https://github.com/apache/spark/pull/11936/files#r57520723 in either of your PR for oth

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-26 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57520723 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -56,9 +55,10 @@ import org.apache.spark.sql.types

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201734206 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201734204 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201734145 **[Test build #54254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54254/consoleFull)** for PR 11936 at commit [`25d894f`](https://g

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201718918 **[Test build #54254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54254/consoleFull)** for PR 11936 at commit [`25d894f`](https://gi

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57510168 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFor

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57510032 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFor

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57510021 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -291,10 +308,10 @@ private[orc] case class OrcTableScan(

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57506577 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFor

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57468288 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -291,10 +308,10 @@ private[orc] case class OrcTableScan( val

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57467951 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFormat

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57467872 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFormat

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201373865 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201373903 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201373230 **[Test build #54183 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54183/consoleFull)** for PR 11936 at commit [`a26973e`](https://g

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57456602 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFor

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57455299 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -117,6 +123,66 @@ private[sql] class DefaultSource extends FileFor

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332833 **[Test build #54183 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54183/consoleFull)** for PR 11936 at commit [`a26973e`](https://gi

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332718 Just realized the problem while washing dishes... The above comment is a false alarm. The real problem is that I ignored start position and length of the `Par

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332139 **[Test build #54182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54182/consoleFull)** for PR 11936 at commit [`2cbb56d`](https://g

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332145 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201332143 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201331875 **[Test build #54182 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54182/consoleFull)** for PR 11936 at commit [`2cbb56d`](https://gi

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201300143 @marmbrus Unfortunately our current strategy for generating Spark partitions doesn't play well with ORC version of `buildReader()`, or to be more specific, `OrcRecord

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201298335 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201298344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201297711 **[Test build #54172 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54172/consoleFull)** for PR 11936 at commit [`7d628ed`](https://g

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201265889 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57440620 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -81,10 +81,10 @@ private[sql] object FileSour

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57440291 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -81,10 +81,10 @@ private[sql] object FileSour

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201262390 **[Test build #54172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54172/consoleFull)** for PR 11936 at commit [`7d628ed`](https://gi

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201259009 cc @cloud-fan @yhuai @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201243933 **[Test build #54169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54169/consoleFull)** for PR 11936 at commit [`b1d630b`](https://g

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201243936 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201243935 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201243792 **[Test build #54169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54169/consoleFull)** for PR 11936 at commit [`b1d630b`](https://gi