Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58602203
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -85,24 +91,23 @@ case class DropFunction(
extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58601677
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -85,24 +91,23 @@ case class DropFunction(
extends
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205957877
Thanks @yhuai @viirya I'm merging this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58600078
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -85,24 +91,23 @@ case class DropFunction(
extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205878605
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205878599
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205878276
**[Test build #54987 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54987/consoleFull)**
for PR 12117 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205831352
**[Test build #54987 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54987/consoleFull)**
for PR 12117 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205654370
LGTM now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205652627
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205652624
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205652502
**[Test build #54948 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54948/consoleFull)**
for PR 12117 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205629207
**[Test build #54948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54948/consoleFull)**
for PR 12117 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58483084
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/UDFSuite.scala
---
@@ -32,4 +68,122 @@ class UDFSuite extends QueryTest with TestHiveSingleton
{
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205625938
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205625930
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205625867
**[Test build #54945 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54945/consoleFull)**
for PR 12117 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205623750
**[Test build #54945 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54945/consoleFull)**
for PR 12117 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58482346
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -201,8 +201,13 @@ class TestHiveContext private[hive](
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205616654
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205616658
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205616585
**[Test build #54931 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54931/consoleFull)**
for PR 12117 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205600013
**[Test build #54931 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54931/consoleFull)**
for PR 12117 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58478223
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -201,8 +201,13 @@ class TestHiveContext private[hive](
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58478146
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/UDFSuite.scala
---
@@ -32,4 +68,122 @@ class UDFSuite extends QueryTest with TestHiveSingleton
{
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58477709
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -208,6 +261,118 @@ class HiveSparkSubmitSuite
}
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58475394
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -21,19 +21,19 @@ import scala.collection.JavaConverters._
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58475308
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58474474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205570551
Thanks @yhuai for improving the original changes. This looks great now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58474075
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58474058
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58473612
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58473408
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -396,18 +400,16 @@ case class ShowFunctions(db:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58473230
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -396,18 +400,16 @@ case class ShowFunctions(db:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58473121
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -159,6 +160,7 @@ abstract class ExternalCatalog {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58473146
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -208,6 +208,22 @@ class SQLContext private[sql](
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58472917
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -146,6 +146,7 @@ abstract class ExternalCatalog {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58472808
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -534,17 +579,11 @@ class SessionCatalog(
val
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58472800
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -524,7 +537,39 @@ class SessionCatalog(
*
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58472516
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -524,7 +537,39 @@ class SessionCatalog(
*
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58472493
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog(
*/
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58472415
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog(
*/
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58472439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -453,28 +464,80 @@ class SessionCatalog(
* If
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58472411
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog(
*/
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58472254
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog(
*/
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58471970
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -341,9 +343,14 @@ object FunctionRegistry {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58471897
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -52,6 +52,8 @@ trait FunctionRegistry {
/**
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58471886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -49,7 +49,6 @@ object SimpleAnalyzer
class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12117#issuecomment-205560436
Thanks @yhuai. This looks pretty good. I left a few suggestions on how the
documentation, code readability and placement of functionality can be improved,
but these
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58469841
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -341,9 +343,14 @@ object FunctionRegistry {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58469061
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,85 @@ class SessionCatalog(
*/
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58468638
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58467158
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466809
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466759
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -21,19 +21,19 @@ import
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466595
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -17,27 +17,39 @@
package org.apache.spark.sql.hive
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466640
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -112,4 +124,129 @@ class HiveSessionCatalog(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466523
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466538
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466440
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58466044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58465870
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58465597
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58465188
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -396,18 +400,16 @@ case class ShowFunctions(db:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58465066
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -396,18 +400,16 @@ case class ShowFunctions(db:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456861
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -208,6 +208,22 @@ class SQLContext private[sql](
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456814
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -208,6 +208,22 @@ class SQLContext private[sql](
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456761
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -208,6 +208,22 @@ class SQLContext private[sql](
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -146,6 +146,7 @@ abstract class ExternalCatalog {
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58456466
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -524,7 +537,39 @@ class SessionCatalog(
73 matches
Mail list logo
