Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r58168784
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r58120693
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r58091330
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql: String)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r58006853
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57990860
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57979921
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql: String)
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203175309
Thank you for your reviews!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12009
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57823588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql:
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203170273
Oh good timing. Merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203170040
LGTM will merge this once tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203170069
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203170065
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203169871
**[Test build #54468 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54468/consoleFull)**
for PR 12009 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57823462
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -45,46 +45,135 @@ abstract class NativeDDLCommand(val sql:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57823320
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -97,7 +97,8 @@ private[sql] class SparkQl(conf: ParserConf =
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203169540
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203161018
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203161016
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203160828
**[Test build #54461 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54461/consoleFull)**
for PR 12009 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203133823
**[Test build #54468 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54468/consoleFull)**
for PR 12009 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-203116744
**[Test build #54461 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54461/consoleFull)**
for PR 12009 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57679169
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -318,6 +320,138 @@ case class DescribeCommand(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57679159
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -318,6 +320,138 @@ case class DescribeCommand(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57679194
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -104,6 +104,13 @@ class
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-202743732
Sure, will do the changes. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-202687564
I just merged https://github.com/apache/spark/pull/12015
Can you update to use the new ANTLR4 parser instead? We are going to remove
the ANTLR3 one in the next
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57665228
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -318,6 +320,138 @@ case class DescribeCommand(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57660013
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -318,6 +320,138 @@ case class DescribeCommand(
}
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-202601202
Looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57642492
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -318,6 +320,138 @@ case class DescribeCommand(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57642335
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -104,6 +104,13 @@ class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57642224
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -104,6 +104,13 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57641072
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57641047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -39,7 +39,7 @@ abstract class ExternalCatalog {
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57639140
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57638935
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -39,7 +39,7 @@ abstract class ExternalCatalog {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57630288
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -39,7 +39,7 @@ abstract class ExternalCatalog {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57629952
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -104,6 +104,13 @@ class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-202562807
**[Test build #54348 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54348/consoleFull)**
for PR 12009 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-202562851
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-202562845
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57624324
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -39,7 +39,7 @@ abstract class ExternalCatalog {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12009#discussion_r57624245
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -104,6 +104,13 @@ class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12009#issuecomment-202555613
**[Test build #54348 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54348/consoleFull)**
for PR 12009 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/12009
[SPARK-14124] [SQL] Implement Database-related DDL Commands
What changes were proposed in this pull request?
This PR is to implement the following four Database-related DDL commands:
46 matches
Mail list logo
