[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58624011 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -410,116 +407,41 @@ class SparkSqlAstBuilder extends AstBuild

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58622715 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -292,11 +357,53 @@ case class AlterTableSetFileFormat(

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205997358 Seems "Checking for ability to automatically merge…" is taking a long time. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205996108 LGTM. Just have one comment for altering the location of a partition. But, we can address that in a follow-up PR. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58618530 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -292,11 +357,53 @@ case class AlterTableSetFileFormat( gener

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58618579 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -292,11 +357,53 @@ case class AlterTableSetFileFormat( gener

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205991505 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205991503 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14129][SPARK-14128][SQL] Alter table DD...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12121#issuecomment-205991229 **[Test build #55011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55011/consoleFull)** for PR 12121 at commit [`79c86aa`](https://g