Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205963079
**[Test build #55011 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55011/consoleFull)**
for PR 12121 at commit
[`79c86aa`](https://gi
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205901169
I think this PR also resolves another JIRA:
https://issues.apache.org/jira/browse/SPARK-14128 Thanks!
---
If your project is set up for it, you can reply to this em
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205835272
Looks like those failed tests were caused by altering cluster by related
metadata. Can you take a look at those test files? We can extract useful parts
of those query fil
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205537312
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205537314
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205537187
**[Test build #54886 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54886/consoleFull)**
for PR 12121 at commit
[`89fbe97`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205514753
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205514751
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205514543
**[Test build #54889 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54889/consoleFull)**
for PR 12121 at commit
[`d030ae0`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205511129
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205511127
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205510927
**[Test build #54885 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54885/consoleFull)**
for PR 12121 at commit
[`dd243cd`](https://g
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58448177
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -410,116 +407,41 @@ class SparkSqlAstBuilder extends AstBuild
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58445982
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -410,116 +407,41 @@ class SparkSqlAstBuilder extends AstBuild
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58444971
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -410,116 +407,41 @@ class SparkSqlAstBuilder extends AstBuild
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205479800
**[Test build #54889 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54889/consoleFull)**
for PR 12121 at commit
[`d030ae0`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205478451
**[Test build #54886 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54886/consoleFull)**
for PR 12121 at commit
[`89fbe97`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-205477094
**[Test build #54885 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54885/consoleFull)**
for PR 12121 at commit
[`dd243cd`](https://gi
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58440925
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -312,11 +378,38 @@ case class AlterTableSetFileFormat(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58440884
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -195,67 +195,133 @@ case class DropFunction(
isTemp: Bo
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58428893
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58422822
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -195,67 +195,133 @@ case class DropFunction(
isTemp: Boolean
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58418639
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -195,67 +195,133 @@ case class DropFunction(
isTemp: Bo
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58418148
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -547,4 +552,23 @@ class SessionCatalog(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58418160
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -409,116 +406,40 @@ class SparkSqlAstBuilder extends AstBuild
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58412875
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58412711
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58301016
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -195,67 +195,133 @@ case class DropFunction(
isTemp: Boolean
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58300971
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -195,67 +195,133 @@ case class DropFunction(
isTemp: Boolean
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58300930
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with
Share
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58300927
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with
Share
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58300876
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with
Share
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58300859
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with
Share
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58300866
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with
Share
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58300797
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with
Share
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58300635
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -19,34 +19,62 @@ package org.apache.spark.sql.execution.command
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-204771583
@andrewor14 Thank you for working on this! I have finished my review of the
command implementation part. I will go through the test part this afternoon.
---
If your proj
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58297825
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -312,11 +378,38 @@ case class AlterTableSetFileFormat(
gener
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58297607
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -195,67 +195,133 @@ case class DropFunction(
isTemp: Boolean
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58297318
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -409,116 +406,40 @@ class SparkSqlAstBuilder extends AstBuilder {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58296859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -547,4 +552,23 @@ class SessionCatalog(
funct
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58285705
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -195,67 +195,133 @@ case class DropFunction(
isTemp: Bo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-204619704
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-204619702
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-204619539
**[Test build #54740 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54740/consoleFull)**
for PR 12121 at commit
[`6684909`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-204618992
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-204618945
**[Test build #54739 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54739/consoleFull)**
for PR 12121 at commit
[`00d2513`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-204618993
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12121#discussion_r58281677
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -195,67 +195,133 @@ case class DropFunction(
isTemp: Boolea
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-204607555
**[Test build #54740 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54740/consoleFull)**
for PR 12121 at commit
[`6684909`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12121#issuecomment-204606942
**[Test build #54739 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54739/consoleFull)**
for PR 12121 at commit
[`00d2513`](https://gi
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/12121
[SPARK-14129][SQL] Alter table DDL commands
## What changes were proposed in this pull request?
In Spark 2.0, we want to handle the most common `ALTER TABLE` commands
ourselves instead
52 matches
Mail list logo
