Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204472946
Thanks, Herman.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12069
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204461425
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204154484
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204153532
**[Test build #2719 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2719/consoleFull)**
for PR 12069 at commit
[`31ae9d5`](https://
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204128122
Yeah that is a bit funny. I triggered another build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204127406
The failed test in previous run :
org.apache.spark.sql.sources.JsonHadoopFsRelationSuite passes for me on my
local machine.
---
If your project is set up fo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204117461
**[Test build #2719 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2719/consoleFull)**
for PR 12069 at commit
[`31ae9d5`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204114386
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204114380
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204114199
**[Test build #54655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54655/consoleFull)**
for PR 12069 at commit
[`31ae9d5`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204087653
**[Test build #54655 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54655/consoleFull)**
for PR 12069 at commit
[`31ae9d5`](https://gi
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204086412
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204074553
Thanks for reviewing the PR , Andrew. I rebased it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-204046795
@sureshthalamati can you rebase now? We just removed antlr 3 and related
files
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-203749355
Thanks for the input, Herman. Addressed the review comments , and fixed
the test failure in my latest commit.
---
If your project is set up for it, you can
Github user sureshthalamati commented on a diff in the pull request:
https://github.com/apache/spark/pull/12069#discussion_r58000282
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -167,6 +167,11 @@ unsupportedHiveNativeCommands
Github user sureshthalamati commented on a diff in the pull request:
https://github.com/apache/spark/pull/12069#discussion_r5740
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -861,6 +866,7 @@ ROLES: 'ROLES';
COMPACTIONS:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-203596495
**[Test build #2709 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2709/consoleFull)**
for PR 12069 at commit
[`6f46e32`](https://
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-203563226
@sureshthalamati thanks for working on this. The `ALTER TABLE table TOUCH
[PARTITION spec]` command has already been implemented.
---
If your project is set up for
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12069#discussion_r57936230
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -167,6 +167,11 @@ unsupportedHiveNativeCommands
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-203559263
**[Test build #2709 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2709/consoleFull)**
for PR 12069 at commit
[`6f46e32`](https://g
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12069#discussion_r57935256
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -861,6 +866,7 @@ ROLES: 'ROLES';
COMPACTIONS: 'COMP
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12069#discussion_r57934860
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -861,6 +866,7 @@ ROLES: 'ROLES';
COMPACTIONS: 'COMP
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-203555609
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/12069#issuecomment-203554914
This Jira also mentions alter table touch as an unsupported operation. But
there is an explicit parser rule for this command , I was not sure if there is
work i
GitHub user sureshthalamati opened a pull request:
https://github.com/apache/spark/pull/12069
[SPARK-14133][SQL] Throws exception for unsupported create/drop/alter index
, and lock/unlock operations.
## What changes were proposed in this pull request?
This PR throws Unsup
27 matches
Mail list logo
